unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mike Gerwitz <mtg@gnu.org>
Cc: 29480-done@debbugs.gnu.org
Subject: [bug#29480] [PATCH] gnu: Add xautolock.
Date: Sat, 02 Dec 2017 11:02:06 +0100	[thread overview]
Message-ID: <878tel30td.fsf@gnu.org> (raw)
In-Reply-To: <87indq0xhw.fsf@gnu.org> (Mike Gerwitz's message of "Fri, 01 Dec 2017 19:44:27 -0500")

Hi,

Mike Gerwitz <mtg@gnu.org> skribis:

> On Thu, Nov 30, 2017 at 15:56:11 +0100, Ludovic Courtès wrote:
>> I took the liberty to make the changes below:
>
> Ah, thanks!
>
>> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
>> -               (zero? (system* "xmkmf"))
>> +               (invoke "xmkmf")
>
> Okay, that makes much more sense.  I was wondering if `zero?' had some
> special meaning in that context.

‘zero?’ returns a Boolean and in this case it was ignored.

> gnu/packages/xfig.scm:93 uses it in a non-tail position as well.  I
> looked at the history for the file but it was always like that;
> perhaps that should be `invoke' too?

I guess we should!  I’ve made the change and will push soonish.

Thanks,
Ludo’.

      reply	other threads:[~2017-12-02 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  2:50 [bug#29480] [PATCH] gnu: Add xautolock Mike Gerwitz
2017-11-30 14:56 ` bug#29480: " Ludovic Courtès
2017-12-02  0:44   ` [bug#29480] " Mike Gerwitz
2017-12-02 10:02     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tel30td.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=29480-done@debbugs.gnu.org \
    --cc=mtg@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).