From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYThy-00049I-Fa
	for guix-patches@gnu.org; Mon, 08 Jan 2018 04:27:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYThu-0000Cv-EE
	for guix-patches@gnu.org; Mon, 08 Jan 2018 04:27:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:59752)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eYThu-0000Cj-Ab
	for guix-patches@gnu.org; Mon, 08 Jan 2018 04:27:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYTht-0007CQ-V5
	for guix-patches@gnu.org; Mon, 08 Jan 2018 04:27:01 -0500
Subject: [bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.
Resent-Message-ID: <handler.29932.B29932.151540361827665@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180101132200.26157-1-dannym@scratchpost.org>
Date: Mon, 08 Jan 2018 10:26:54 +0100
In-Reply-To: <20180101132200.26157-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Mon, 1 Jan 2018 14:22:00 +0100")
Message-ID: <878td8k8f5.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 29932@debbugs.gnu.org

Hello,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Previously, the accessor for the field "kernel-arguments" in the structure
> <operating-system> was called "operating-system-user-kernel-arguments".
>
> The procedure "operating-system-kernel-arguments" made sure to add argume=
nts
> that made the system boot from a given device.
>
> After some reflection I think I was mistaken in that.
>
> It's nicer if the accessor is called "operating-system-kernel-argmuents"
> and if the users just use "bootable-kernel-arguments" on their own in ord=
er to
> amend them.
>
> That's what this patch does.

I find =E2=80=98bootable-kernel-arguments=E2=80=99 to be quite unusual for =
a public
interface.

It=E2=80=99d feel more idiomatic to me if, instead, we had an
=E2=80=98operating-system-boot-kernel-arguments=E2=80=99 procedure that tak=
es an OS and
returns (list --root --system =E2=80=A6).  Then it=E2=80=99d be up to the c=
aller to
append that to what =E2=80=98operating-system-kernel-arguments=E2=80=99 ret=
urns.

WDYT?

Thanks,
Ludo=E2=80=99.