From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ek5ju-0002XK-4C
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:17:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ek5jr-0001JP-E5
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:17:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:55034)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ek5jr-0001JE-AB
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:17:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ek5jq-00027Y-6K
	for guix-patches@gnu.org; Fri, 09 Feb 2018 05:17:03 -0500
Subject: [bug#30381] gnu: Add gzdoom.
Resent-Message-ID: <handler.30381.B30381.15181714038123@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <e11a636a5bf5d5211b00f9cdef56e076@firemail.cc>
Date: Fri, 09 Feb 2018 11:16:37 +0100
In-Reply-To: <e11a636a5bf5d5211b00f9cdef56e076@firemail.cc>
	(okapi@firemail.cc's message of "Wed, 07 Feb 2018 19:03:24 +0100")
Message-ID: <878tc24ge2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: okapi@firemail.cc
Cc: 30381@debbugs.gnu.org

Hello,

okapi@firemail.cc skribis:

> From f75ca85cd1cc89a3ba60c6c813ae4ab33bc86a40 Mon Sep 17 00:00:00 2001
> From: okapi <okapi@firemail.cc>
> Date: Wed, 17 Jan 2018 00:08:23 +0100
> Subject: [PATCH 1/2] gnu: Add fluid-3.
>
> * gnu/packages/audio.scm (fluid-3): New variable.

Could you add a copyright line for you?  You can use a nickname, that=E2=80=
=99s
fine.

> +(define-public fluid-3
> +  (let ((commit "871c8ce2002e8b3c198f532fdb4fbcce7914f951"))
> +    (package
> +      (name "fluid-3")
> +      (version "2.1")
> +      (source
> +       (origin
> +         (method url-fetch)
> +         ;; Only one file is required, but the release bundles the whole
> +         ;; software which is 50MiB as tar and 200MiB unpacked. The webs=
ite
> +         ;; directly links the soundfont release to the github file down=
load.
> +         (uri (string-append "https://github.com/musescore/MuseScore/raw=
/"
> +                             commit "/share/sound/FluidR3Mono_GM.sf3"))
> +         (file-name (string-append name "-" commit ".tar.gz"))
> +         (sha256
> +          (base32
> +           "1hjfg5i15bw9279007xs92zsggjgn4s4k9pc00s851l3kvc6dkfg"))))
> +      (build-system trivial-build-system)
> +      (arguments
> +       `(#:modules ((guix build utils))
> +         #:builder
> +         (begin
> +           (use-modules (guix build utils))
> +           (let ((file (assoc-ref %build-inputs "source"))
> +                 (out (string-append %output "/share/soundfonts")))
> +             (mkdir-p out)
> +             (copy-file file (string-append out "/FluidR3Mono_GM.sf3")))=
)))

You can write: (install-file file out).

> +      (home-page  "https://github.com/musescore/MuseScore/tree/master/sh=
are/sound")
> +      (synopsis "Pro-quality GM soundfont")
> +      (description "Fluid-3 is Frank Wen's pro-quality GM soundfont.")

I find the synopsis/description a bit vague but I don=E2=80=99t have a bett=
er
suggestion.  :-)

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.