unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31485@debbugs.gnu.org
Subject: [bug#31485] [PATCH] gnu: Add uncrustify.
Date: Sun, 20 May 2018 22:31:40 +0200	[thread overview]
Message-ID: <878t8enk5v.fsf@gnu.org> (raw)
In-Reply-To: <87bmdbw9ny.fsf@gmail.com> (Pierre Neidhardt's message of "Sun, 20 May 2018 00:41:21 +0200")

Hi Pierre,

Pierre Neidhardt <ambrevar@gmail.com> skribis:

>> Maybe: “Indent source code written in C or related languages”?
>> (I wasn’t sure what “beautifier” meant.)
>
> Well, technically "indent" is only about the spacing to the margin.
> Beautifiers (also known as prettifiers or formatters) do more than that,
> they also handle the spacing elsewhere, transform into idiomatic syntax,
> etc.
>
> I'm not sure which is better.  I like "code formatter".

Sure, it’s even clearer.

> * gnu/packages/pretty-print.scm (uncrustify): New variable.

There are two minor issues from my previous email that we should
resolve:

> Perhaps indent.scm or code.scm would be a better match?

and:

> Should be ‘gpl2+’ (version 2 “or any later version”).

I’m happy to fix both on your behalf if that’s fine with you, or you can
send an updated patch.

Let me know!

Thanks,
Ludo’.

  parent reply	other threads:[~2018-05-20 20:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 20:37 [bug#31485] [PATCH] gnu: Add uncrustify Pierre Neidhardt
2018-05-18  6:50 ` Pierre Neidhardt
2018-05-19 20:32 ` Ludovic Courtès
2018-05-19 22:41   ` Pierre Neidhardt
2018-05-20 12:31     ` Pierre Neidhardt
2018-05-20 20:31     ` Ludovic Courtès [this message]
2018-05-20 20:49       ` Pierre Neidhardt
2018-05-23 10:18         ` bug#31485: " Ludovic Courtès
2018-06-16  1:37 ` [bug#31485] 27.0.50; Error building master on MacOS Paul Eggert
2018-06-16 16:16   ` Ludovic Courtès
2018-06-16 16:32     ` [bug#31485] bug#31845: " Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t8enk5v.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31485@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).