From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdzaA-0005Nu-8V for guix-patches@gnu.org; Fri, 13 Jul 2018 11:02:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdza7-0001zW-Gg for guix-patches@gnu.org; Fri, 13 Jul 2018 11:02:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdza7-0001zS-BB for guix-patches@gnu.org; Fri, 13 Jul 2018 11:02:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fdza7-0006VN-1Z for guix-patches@gnu.org; Fri, 13 Jul 2018 11:02:03 -0400 Subject: bug#32114: [PATCH] gnu: Add ddclient. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Oleg Pykhalov References: <20180710162955.10895-1-go.wigust@gmail.com> <20180711190956.GB11727@jasmine.lan> <20180712051338.llgw6bgoaccab6px@abyayala> Date: Fri, 13 Jul 2018 18:01:16 +0300 In-Reply-To: <20180712051338.llgw6bgoaccab6px@abyayala> (Nils Gillmann's message of "Thu, 12 Jul 2018 05:13:38 +0000") Message-ID: <878t6fgoxv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nils Gillmann , Leo Famulari Cc: 32114@debbugs.gnu.org, 32114-done@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Nils, Leo, all. Nils Gillmann writes: > Leo Famulari transcribed 1.3K bytes: >> On Tue, Jul 10, 2018 at 07:29:55PM +0300, Oleg Pykhalov wrote: >> > * gnu/packages/dns.scm (ddclient): New variable. >>=20 >> Thanks! Overall it seems fine, but can you add a short code comment >> about why it uses the trival-build-system instead of perl-build-system? > > I think I tried to work on this a while back. It simply has no Makefile > for any build system. I applied all your suggestions, thank you. Also, while I wrote ddclient service [1] I did some improvements to ddclient package. Pushed as 0bc2d3e42b8800e875f24973f999739297f1f502 with following changes: --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable Content-Description: Applied suggestions to ddclient. diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index b17016909..ffa442f4d 100644 =2D-- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -592,7 +591,7 @@ synthesis, and on-the-fly re-configuration.") (sha256 (base32 "1j8zdn7fy7i0bjk3jf0hxnbnshc2yf054vxq64imxdpfd7n5zgfy")))) =2D (build-system trivial-build-system) + (build-system trivial-build-system) ; no Makefile.PL (native-inputs `(("bash" ,bash) ("gzip" ,gzip) @@ -600,6 +599,7 @@ synthesis, and on-the-fly re-configuration.") ("tar" ,tar))) (inputs `(("net-tools" ,net-tools) + ("inetutils" ,inetutils) ;logger ("perl-io-socket-ssl" ,perl-io-socket-ssl) ("perl-digest-sha1" ,perl-digest-sha1))) (arguments @@ -625,7 +625,13 @@ synthesis, and on-the-fly re-configuration.") (bin (string-append out "/bin"))) (let ((file "ddclient")) (substitute* file =2D (("/usr/bin/perl") (which "perl"))) + (("/usr/bin/perl") (which "perl")) + ;; Strictly use =E2=80=98/etc/ddclient/ddclient.conf=E2= =80=99. + (("\\$\\{program\\}\\.conf") "/etc/ddclient/ddclient.conf= ") + (("\\$etc\\$program.conf") "/etc/ddclient/ddclient.conf") + ;; Strictly use =E2=80=98/var/cache/ddclient/ddclient.cac= he=E2=80=99 + (("\\$cachedir\\$program\\.cache") + "/var/cache/ddclient/ddclient.cache")) (install-file file bin) (wrap-program (string-append bin "/" file) `("PATH" ":" =3D @@ -655,7 +661,7 @@ addresses with several dynamic DNS service providers, s= uch as This makes it possible to use a fixed hostname (such as myhost.dyndns.org)= to access a machine with a dynamic IP address. =20 =2DThis client supports both dynamic and (near) static services, as well as= MX +The client supports both dynamic and (near) static services, as well as MX record and alternative name management. It caches the address, and only attempts the update when it has changed.") (license license:gpl2+))) --=-=-= Content-Type: text/plain [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32141 Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAltIvrwACgkQckbhHGm3 lWk5iBAAg0ZbbSL6a46GZLcWpKspv66mnwRboov7UaGxkTgDylESLM+csmU1jfM3 RO8EzxEDHYSQtXbLFrZT+46Ep3l0DQbALF9BoXNpDQgC8mwbIvjLBV4FtOUKyx4w ubnUvWkkX7gLvOfvZA4yXJhWWQuieh8XhC0qOF1hxqmoh6rT8S5AThKrItENbjIQ aARynJwRx0iF6e5yvJbM4bTOkbe1PBO7w6IlJ5Gg6R8wVkOl6VdubyZWKPjkAo1n zV4Prt4hPikLJRrf44g4DoUTARvRZWtICEVkp+PprEVSzGotrP4jQQh6rX7yHK/t JrE07Umwkg1THnDG61zDKhnMFA+WvUytsEt4Ykvzsw05SwsjzXsaVKGtH/GydI26 JXvnIskbTwJqn5SLCw0/r4+Q+eFItf6Nqy7PGXFxM5M9Dnxpjp1C/mlf5/QZxArH arUQ0H0Xh2prSUqkZ1lN9QZovynf5ybqiXxt5Hrr9GzJri+SeGKwBCI3PcQciV7V +8nIrOqxhpyaYD47oikDfsVWSBr6ZtTKN4gtkjt+c9QDEWy5UbTwK4+MI9BJmBkL daXUIrozn4wG/9GZze8OHnqgrZsQjxvRrOPS/2H1sjeas985F0hyXVs5gDfKpRNR Pd7e8qYwgyNTJytOpRJ4UiX0uHtposhvXa1IxmK+eUauztC24Pg= =VzOx -----END PGP SIGNATURE----- --==-=-=--