unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Benjamin Slade <slade@jnanam.net>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 32638@debbugs.gnu.org
Subject: [bug#32638] [PATCH] games.scm - add frotz packages
Date: Thu, 06 Sep 2018 13:25:22 -0600	[thread overview]
Message-ID: <878t4e77j1.fsf@jnanam.net> (raw)
In-Reply-To: <87o9daa3o0.fsf@posteo.net>

Many thanks, Kei, for the detailed commentary! It's very helpful (I'm
still learning the ropes for guix packaging).

 > In the description, sentences should be separated by two
 > spaces. Running "./pre-inst-env guix lint frotz" will check these
 > sorts of things (and more) automatically for you.

Is there a way to do this directly in Emacs, do you know?

 > Why the git checkout? I assume the stable version's SDL port is not working?

Yes, stable's SDL port doesn't build. (I notice that sfrotz/frotz-sdl
seems to be missing from a number of distros, presumably for this
reason).

 > Other than the comments above, all of the packages here work fine!
 > Thanks for contributing!

I'll fix things up along the lines suggested and resubmit.

thanks again,
   —Ben


--
Dr Benjamin Slade - Dept of Linguistics, Uni of Utah
   (https://slade.jnanam.net . https://babbagefiles.xyz)
  `(pgp_fp: ,(21BA 2AE1 28F6 DF36 110A 0E9C A320 BBE8 2B52 EE19))
    '(sent by mu4e on Emacs running under GNU/Linux . https://gnu.org )
       `(Choose Linux ,(Choose Freedom) . https://linux.com )

  reply	other threads:[~2018-09-06 19:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  2:43 [bug#32638] [PATCH] games.scm - add frotz packages Benjamin Slade
2018-09-06 18:20 ` Kei Kebreau
2018-09-06 19:25   ` Benjamin Slade [this message]
2018-09-08  3:08 ` Benjamin Slade
2018-09-08 17:47   ` bug#32638: " Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t4e77j1.fsf@jnanam.net \
    --to=slade@jnanam.net \
    --cc=32638@debbugs.gnu.org \
    --cc=kkebreau@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).