From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZgZi-0001Fy-G1 for guix-patches@gnu.org; Wed, 19 Dec 2018 13:28:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZgZe-00015g-HR for guix-patches@gnu.org; Wed, 19 Dec 2018 13:28:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50826) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZgZe-00015c-Dy for guix-patches@gnu.org; Wed, 19 Dec 2018 13:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZgZe-00084B-65 for guix-patches@gnu.org; Wed, 19 Dec 2018 13:28:02 -0500 Subject: [bug#33549] [PATCH 6/6] services: monitoring: Add 'zabbix-front-end'. Resent-Message-ID: From: Oleg Pykhalov References: <20181129185042.6050-1-go.wigust@gmail.com> <20181129185042.6050-6-go.wigust@gmail.com> <87efadv8nq.fsf@gnu.org> Date: Wed, 19 Dec 2018 21:27:28 +0300 In-Reply-To: <87efadv8nq.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 19 Dec 2018 16:27:37 +0100") Message-ID: <878t0lpe27.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33549-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, Thank you for review. Ludovic Court=C3=A8s writes: [=E2=80=A6] >> +$DB['PASSWORD'] =3D '" (if (string-null? db-password) >> + (if (string-null? db-secret-file) >> + (display "Provide a `db-secret-file' \ >> +or `db-password' field. >> +" >> + (current-error-port)) >> + (string-trim-both >> + (with-input-from-file db-secret-file >> + read-string))) >> + (begin >> + (display " >> +Hint: Consider use `db-secret-file' instead of `db-password' and unset >> +`db-password' in `zabbix-front-end-configuration' for security. >> +") >> + db-password)) "'; >> + >> +// Schema name. Used for IBM DB2 and PostgreSQL. >> +$DB['SCHEMA'] =3D ''; >> + >> +$ZBX_SERVER =3D '" zabbix-host "'; >> +$ZBX_SERVER_PORT =3D '" (number->string zabbix-port) "'; >> +$ZBX_SERVER_NAME =3D ''; >> + >> +$IMAGE_FORMAT_DEFAULT =3D IMAGE_FORMAT_PNG; >> +")))) > > I saw these =E2=80=9Chints=E2=80=9D in the build log of Cuirass and that = got me curious. > :-) Do you mean =E2=80=9Chints=E2=80=9D during =E2=80=98zabbix=E2=80=99 tests? > A couple of comments=E2=80=A6 For consistency, hints should be reported = using > the =E2=80=98display-hint=E2=80=99 procedure, which takes a Texinfo strin= g as input. > > Second, while the second =E2=80=98display=E2=80=99 call does look like a = hint, the first > one looks like it should be an error, shouldn=E2=80=99t it? In that case= , I=E2=80=99d > suggest something like: > > (raise (condition > (&message > (message "You must provide either 'db-secret-file' or 'db-pas= sword'.")))) Thanks, pushed as 0485717ee94e7f161d072f017edce5d35df49c81 to master. > Third, it would be nice to report source location info along with hints > and errors. To do that, you could add an innate =E2=80=98location=E2=80= =99 field to > as done for . Then, along > with the &message condition above, you could raise an &error-location as > is done in a few places. > > Does that make sense? Sure. I see innate location field in , but unfortunately I'm not sure how to implement it, because we use define-configuration for . So the implementation of that feature may take a time. ;-) > Anyway thanks for this patch series, we=E2=80=99ll probably put it to goo= d use > on the build farm! Feel free to ping me. Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAlwajZAACgkQFn+OpQAa +pxZ5w/7BGDv/ni1oZziA96kk8imzamuFsHAzWSR+vZ4aDUt/fCfghuB/wXa2JBr +Rol3oT6WjRxigKWyNthgb/6cTGTwkJul9RtzSwWb/Hk/LN++nAbdxzoXzt40pXh w6CVpGxnNTn7XB75rFhCQciC+uF5gLKsxWyO+dnw5fjDgHPPkeGvkYcQFbjWA+fz kkqmy7PNO4akBF5z4D2r8KVaa7rLpBvqXG7h6DXmKRE50qUSnM0fwMyjxQTx10OR ZCzOm4crD6x9DgT5v7HVT7crkrRlNHWfLFxEbFuBpxZ57h7vtlZdL5IrmBABqE7Q v6wwl7AiomgzQnxCtPhg4wE+k3Awv5ODgzh+ZLwIbLt8YQTJ1R2jqJdYyka/DH6D NKwiN5zcMYtvrMR8Apq+tBfKSUguVctOBFryneIeZ5rxZ83HCLCSe1glvtfm2IRp OP7kItM4p35oGVnWkeVcsd31noXnlvuI+zOy0wNzf13dPRc6zxWfo8iGU4ScL8x9 uBINl0kCtpMKKo7oZkPrG9a15WubBkUYUMrxMZROehN2PmEOVrVkdoCp8n3wrerT 5Q6JeaC4js4o2P4SQ2/Wk3FKHFW4eI3R8SmgMOykb3UO7tZslrO66jFbyO4JAQEW QqWzTbtWuGnTDpN4lZTVn/xB4QYsKrVA0skCfzrxzjV+pYufvRY= =BF3Z -----END PGP SIGNATURE----- --=-=-=--