From: Meiyo Peng <meiyo.peng@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33849@debbugs.gnu.org
Subject: [bug#33849] [PATCH] gnu: Add polybar
Date: Mon, 24 Dec 2018 14:27:33 +0800 [thread overview]
Message-ID: <878t0f5tii.fsf@gmail.com> (raw)
In-Reply-To: <87imzkfe3g.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://github.com/jaagr/polybar/releases/"
>> + "download/" version "/polybar.tar"))
>> + (sha256
>> + (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"))
>> + (file-name (string-append name "-" version ".tar"))))
>
> Please use ‘git-fetch’ rather than downloading a generated tarball (it’s
> a generated tarball, right?).
No. This is a user uploaded release tarball. You can notice their
difference. User uploaded tarball has "/releases/download/" in its URL.
#+BEGIN_EXAMPLE
User uploaded: https://github.com/jaagr/polybar/releases/download/3.3.0/polybar.tar
Auto generated: https://github.com/jaagr/polybar/archive/3.3.0.tar.gz
#+END_EXAMPLE
I tried to use the git-fetch method first, but it failed to build
because git-fetch doesn't fetch git submodules. Do we support
recursively fetching git submodules?
>> + (build-system cmake-build-system)
>> + (arguments
>> + ;; Test is disabled because it requires downloading googletest from the
>> + ;; Internet.
>> + '(#:tests? #f))
>
> Did you try adding ‘googletest’ to ‘native-inputs’, and perhaps also
> disabling the code that tries to download it?
I checked the CMakeLists.txt, but it's too complex for me. I am not
familiar with cmake, so I prefer not to patch it.
> The rest LGTM! Could you send an updated patch?
The author released a new version after I sent the last patch. So here
is a new patch with version 3.3.0.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-polybar.patch --]
[-- Type: text/x-patch, Size: 2465 bytes --]
From 3faa9dcf77ca83972db6234a9af6b22325ee0311 Mon Sep 17 00:00:00 2001
From: Meiyo Peng <meiyo.peng@gmail.com>
Date: Sun, 23 Dec 2018 23:05:38 +0800
Subject: [PATCH] gnu: Add polybar.
* gnu/packages/wm.scm (polybar): New variable.
---
gnu/packages/wm.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 2e211e389..a761bce23 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -76,6 +76,7 @@
#:use-module (gnu packages lua)
#:use-module (gnu packages linux)
#:use-module (gnu packages suckless)
+ #:use-module (gnu packages mpd)
#:use-module (guix download)
#:use-module (guix git-download))
@@ -1051,3 +1052,45 @@ its size
@item Display preview images in a tiled icon layout
@end itemize")
(license license:gpl2+)))
+
+(define-public polybar
+ (package
+ (name "polybar")
+ (version "3.3.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/jaagr/polybar/releases/"
+ "download/" version "/polybar.tar"))
+ (sha256
+ (base32 "0sjh3xmf11g09spi88zj7xsc3a3vv78kixab6n5i7436py7xwzb4"))
+ (file-name (string-append name "-" version ".tar"))))
+ (build-system cmake-build-system)
+ (arguments
+ ;; Test is disabled because it requires downloading googletest from the
+ ;; Internet.
+ '(#:tests? #f))
+ (inputs
+ `(("alsa-lib" ,alsa-lib)
+ ("cairo" ,cairo)
+ ("i3-wm" ,i3-wm)
+ ("libmpdclient" ,libmpdclient)
+ ("libnl" ,libnl)
+ ("libxcb" ,libxcb)
+ ("pulseaudio" ,pulseaudio)
+ ("xcb-proto" ,xcb-proto)
+ ("xcb-util" ,xcb-util)
+ ("xcb-util-cursor" ,xcb-util-cursor)
+ ("xcb-util-image" ,xcb-util-image)
+ ("xcb-util-wm" ,xcb-util-wm)
+ ("xcb-util-xrm" ,xcb-util-xrm)))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("python-2" ,python-2) ; lib/xpp depends on python 2
+ ("python" ,python))) ; xcb-proto depends on python 3
+ (home-page "https://polybar.github.io/")
+ (synopsis "Fast and easy-to-use status bar")
+ (description "Polybar aims to help users build beautiful and highly
+customizable status bars for their desktop environment. It has built-in
+functionality to display information about the most commonly used services.")
+ (license license:expat)))
--
2.20.0
[-- Attachment #3: Type: text/plain, Size: 43 bytes --]
--
Meiyo Peng
https://www.pengmeiyu.com/
next prev parent reply other threads:[~2018-12-24 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 15:38 [bug#33849] [PATCH] gnu: Add polybar Meiyo Peng
2018-12-23 17:41 ` Ludovic Courtès
2018-12-24 6:27 ` Meiyo Peng [this message]
2018-12-25 16:45 ` bug#33849: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t0f5tii.fsf@gmail.com \
--to=meiyo.peng@gmail.com \
--cc=33849@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).