From: "Ludovic Courtès" <ludo@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 34097@debbugs.gnu.org
Subject: [bug#34097] [PATCH] import: github: Do not update URI for packages using git-fetch.
Date: Wed, 16 Jan 2019 11:48:00 +0100 [thread overview]
Message-ID: <878szkx4in.fsf@gnu.org> (raw)
In-Reply-To: <cu7h8e8lxl6.fsf@systemreboot.net> (Arun Isaac's message of "Wed, 16 Jan 2019 15:43:09 +0530")
Hi,
Arun Isaac <arunisaac@systemreboot.net> skribis:
> During `guix refresh PACKAGE`, the source URI for packages using
> git-fetch need not be updated. It can be returned unchanged, as it
> is. The attached patch does that.
>
> As a side issue, without this patch, git-fetch packages that do not have
> a source URI ending in ".git" are not updated correctly using `guix
> refresh PACKAGE`. See the package emacs-evil for an example.
>
> From f63bf518395a06dd0c947222e177a66e59c59e96 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Wed, 16 Jan 2019 15:21:06 +0530
> Subject: [PATCH] import: github: Do not update URI for packages using
> git-fetch.
>
> * guix/import/github.scm (updated-github-url): Return the unchanged source URI
> for packages using git-fetch.
> [updated-url]: Do not handle URIs which end with ".git".
LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2019-01-16 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 10:13 [bug#34097] [PATCH] import: github: Do not update URI for packages using git-fetch Arun Isaac
2019-01-16 10:48 ` Ludovic Courtès [this message]
2019-01-16 14:32 ` Eric Bavier
2019-01-16 16:21 ` bug#34097: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878szkx4in.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34097@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).