From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34004) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhvpn-0006LI-FS for guix-patches@gnu.org; Mon, 01 Jul 2019 08:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhvpm-0003vN-Ex for guix-patches@gnu.org; Mon, 01 Jul 2019 08:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhvpm-0003v6-AW for guix-patches@gnu.org; Mon, 01 Jul 2019 08:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhvpm-0003Sw-7d for guix-patches@gnu.org; Mon, 01 Jul 2019 08:55:02 -0400 Subject: [bug#36404] [PATCH 0/6] Add 'guix deploy'. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87o92ianbj.fsf@sdf.lonestar.org> <87o92glap5.fsf@dustycloud.org> Date: Mon, 01 Jul 2019 14:53:53 +0200 In-Reply-To: <87o92glap5.fsf@dustycloud.org> (Christopher Lemmer Webber's message of "Sat, 29 Jun 2019 10:37:10 -0400") Message-ID: <878sthoqzi.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Lemmer Webber Cc: 36404@debbugs.gnu.org Hi! Christopher Lemmer Webber skribis: > Jakob L. Kreuze writes: [...] >> There are two things in this patch series that I'd like comments on in >> particular. >> >> First, I still haven't figured out the whole testing situation. The >> tests, as of now, spin up a virtual machine, create a machine instance, >> deploy that to the virtual machine, and then make assertions about >> changes made to the system. These tests were originally in the system >> test suite as they deal with virtual machines, but I've since moved it >> into the normal Guix test suite because of how much needs to be done on >> the host side -- I spent an absurd amount of time trying to fit a call >> to 'deploy-machine' into a derivation that could be run by the system >> test suite, but I just wasn't able to make it work. I'm hoping someone >> will have thoughts about how we can test 'guix deploy'. Should we have >> them disabled by default? Is there some way to implement them in the a >> system test suite that I've overlooked? Should the tests be included at >> all? > > Ludo, do you have comments? I suspect this is up your area of expertise. As Ricardo wrote, I think that=E2=80=99s too much work to do in =E2=80=9Cma= ke check=E2=80=9D. Plus this would only run when a =E2=80=9Chost store=E2=80=9D is available, = as we can=E2=80=99t reasonably build QEMU and everything in $builddir/test-tmp. So I feel that the system test suite is a better fit, but I don=E2=80=99t f= ully understand the limitations you hit, Jakob. Do you still have a draft of a system test that you wrote and/or notes about what went wrong? Ludo=E2=80=99.