From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:49675)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4ut-0003VA-0D
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:49:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4us-0003E6-5V
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:49:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43013)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hj4us-0003Dv-0j
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hj4ur-0000ir-U5
 for guix-patches@gnu.org; Thu, 04 Jul 2019 12:49:01 -0400
Subject: [bug#36404] [PATCH 0/6] Add 'guix deploy'.
Resent-Message-ID: <handler.36404.B36404.15622589162732@debbugs.gnu.org>
From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze)
References: <87o92ianbj.fsf@sdf.lonestar.org> <87o92glap5.fsf@dustycloud.org>
 <878sthoqzi.fsf@gnu.org> <87r2799tzd.fsf@sdf.lonestar.org>
 <87d0isrsmk.fsf@sdf.lonestar.org>
Date: Thu, 04 Jul 2019 12:48:15 -0400
In-Reply-To: <87d0isrsmk.fsf@sdf.lonestar.org> (Jakob L. Kreuze's message of
 "Tue, 02 Jul 2019 18:14:43 -0400")
Message-ID: <878std3fw0.fsf@sdf.lonestar.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 36404@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Hi Ludovic + Ricardo,

Something hit me today. There aren't any tests for 'guix system
reconfigure'. There are for 'guix system init' in
'gnu/tests/install.scm', but not for 'guix system reconfigure', which
makes me think that I'm going about testing this the wrong way. I feel I
should begin by isolate the behavior that's common between 'guix system
reconfigure' and 'guix deploy' as you suggested, and then writing tests
for that common code in the system test suite. Then, as Ricardo
suggested, mocking can be used for the parts that are specific only to
'guix deploy'.

I will look into this today and report back.

Regards,
Jakob

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl0eLc8ACgkQ9Qb9Fp2P
2VpQlQ//aGcTvwx5ZgaLunEUdAf0zMUhf364Xncz9kfQsCMvVr6iaAbppbkMAb1x
XEk8MYeow+MENm4sACkP154lrgdF7AY+P44rHgAnPwrTtfEfXIPUU5Xhjy6o8MlN
1ahhSA/6cTubl5grBZXexUVvYycZtkYN3zs3uojiFHW5gYiJgqurGfHQrJDcvgVb
kL9qYWGj7+HEUULfDDz9wui47AbNAD0QtTPe+cOSYhste9ywQZohEGPJ74nANDl7
0riRA+21HoxQsMYlfax7fSx+T4aqKaihIMh23WFScxXvofL/5WiHxkWrI1xqVb7X
/pKmSb+nL+adihCjU+szCqYqVDT5L26NTBYGGQjBT3ffVfmRLjZDtFi2rMOUezPT
l4gCQ/im6OKt+zuenw1ofEFEQO2+uHTv3jPPsdrIlX0Dezk+agYkw/5SqxZuZ2fT
LyPyeRWp++ZLTTSq1eXzo2KIrKNvvdWZ6eHXLk5aiQRUcjcPtDcyePs2s6Gm9DH7
fqWrc3OEuPacTwGIa1Xr4t6KPry+LpUEroiVhYOsG3lxgrbAEBKKdFNvqMzsOQey
TwaJA9QC/ig9XcADKz6VY9dGtRqiPY6Vc4jyWgS9wYw7/VIyD3jRmwSCgW2T42Vm
f/S20tOvHpg3vcEn0HS/PLLKs1a29kltCUKUFJqlDdlfiEjXeew=
=TpuR
-----END PGP SIGNATURE-----
--=-=-=--