unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: Tanguy Le Carrour <tanguy@bioneland.org>
Cc: 37613@debbugs.gnu.org
Subject: [bug#37613] [PATCH] gnu: Add python-httpie.
Date: Thu, 17 Oct 2019 23:13:57 +0300	[thread overview]
Message-ID: <878spj6sfu.fsf@gmail.com> (raw)
In-Reply-To: <20191014114320.fmiev2vxisikagf7@rafflesia> (Tanguy Le Carrour's message of "Mon, 14 Oct 2019 13:43:20 +0200")

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

Hello,

Thank you for packaging this tool!

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> From 13062545e9df7f9cab728f6ee17b572a88a11e31 Mon Sep 17 00:00:00 2001
> From: Tanguy Le Carrour <tanguy@bioneland.org>
> Date: Fri, 4 Oct 2019 08:44:59 +0200
> Subject: [PATCH] gnu: Add python-httpie.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/python-web.scm (python-httpie): New public variable.
> ---
>  gnu/packages/python-web.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index ffef3319f7..b980b83a70 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -30,6 +30,7 @@
>  ;;; Copyright © 2019 Vagrant Cascadian <vagrant@debian.org>
>  ;;; Copyright © 2019 Brendan Tildesley <mail@brendan.scot>
>  ;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
> +;;; Copyright © 2019 Tanguy Le Carrour <tanguy@bioneland.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -303,6 +304,34 @@ other HTTP libraries.")
>  (define-public python2-httplib2
>    (package-with-python2 python-httplib2))
>  
> +(define-public python-httpie
> +  (package
> +    (name "python-httpie")

[…]

LGTM.  

What do you think about naming the package “httpie” instead, because
it's intended to run by calling ‘httpie’ command as in ‘youtube-dl’
package?  I could change the name if you don't mind and push it.

Regards,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-10-17 20:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04  6:55 [bug#37613] [PATCH 0/1] gnu: Add python-httpie Tanguy Le Carrour
2019-10-04  6:57 ` [bug#37613] [PATCH 1/1] " Tanguy Le Carrour
2019-10-14  9:56 ` [bug#37613] Updating commit messages Tanguy Le Carrour
2019-10-14 11:43 ` [bug#37613] [PATCH] gnu: Add python-httpie Tanguy Le Carrour
2019-10-17 20:13   ` Oleg Pykhalov [this message]
2019-10-18 12:50     ` Tanguy Le Carrour
2019-10-18 15:09       ` bug#37613: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878spj6sfu.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=37613@debbugs.gnu.org \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).