From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48966)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iXQiB-00018x-He
 for guix-patches@gnu.org; Wed, 20 Nov 2019 09:12:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iXQiA-0005QN-K4
 for guix-patches@gnu.org; Wed, 20 Nov 2019 09:12:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:40361)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iXQiA-0005QJ-Ex
 for guix-patches@gnu.org; Wed, 20 Nov 2019 09:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iXQiA-0007tA-7Z
 for guix-patches@gnu.org; Wed, 20 Nov 2019 09:12:02 -0500
Subject: [bug#38240] [PATCH v3] services: sysctl: Make service one-shot.
Resent-Message-ID: <handler.38240.B38240.157425906830258@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191116214206.20590-1-efraim@flashner.co.il>
 <20191118082111.GF15074@E5400> <877e3wryis.fsf@gnu.org>
 <20191119100053.GP15074@E5400>
Date: Wed, 20 Nov 2019 15:10:57 +0100
In-Reply-To: <20191119100053.GP15074@E5400> (Efraim Flashner's message of
 "Tue, 19 Nov 2019 12:00:53 +0200")
Message-ID: <878soaprim.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38240@debbugs.gnu.org

Hello!

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 796bf6d1b58d675b04198e536bae62552b16da75 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Sat, 16 Nov 2019 23:33:31 +0200
> Subject: [PATCH] services: sysctl: Make service one-shot.
>
> * gnu/services/sysctl.scm (sysctl-shepherd-service): Adjust shepherd
> service to use the 'one-shot?' keyword. Remove 'stop' command. Remove
> 'respawn' option.
> ---
>  gnu/services/sysctl.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/services/sysctl.scm b/gnu/services/sysctl.scm
> index 5e9e6f0661..2110b80395 100644
> --- a/gnu/services/sysctl.scm
> +++ b/gnu/services/sysctl.scm
> @@ -58,9 +58,8 @@
>          (documentation "Configure kernel parameters at boot.")
>          (provision '(sysctl))
>          (start #~(lambda _
> -                   (zero? (system* #$sysctl "--load" #$sysctl.conf))))
> -        (stop #~(const #t))
> -        (respawn? #f))))))
> +                   (invoke #$sysctl "--load" #$sysctl.conf)))
> +        (one-shot? #t))))))

Perhaps we=E2=80=99d rather keep the (zero? (system* =E2=80=A6)) idiom here=
, so that
=E2=80=98herd start=E2=80=99 gracefully reports failure of =E2=80=98sysctl=
=E2=80=99.

Apart from that, it=E2=80=99s all good to me!  :-)

Ludo=E2=80=99.