From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idOzw-0001d2-NG for guix-patches@gnu.org; Fri, 06 Dec 2019 20:35:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idOzv-0000k9-6P for guix-patches@gnu.org; Fri, 06 Dec 2019 20:35:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idOzu-0000fl-UU for guix-patches@gnu.org; Fri, 06 Dec 2019 20:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idOzt-0007X7-Rc for guix-patches@gnu.org; Fri, 06 Dec 2019 20:35:01 -0500 Subject: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0 Resent-Message-ID: From: Brett Gilio References: <20191206085713.27096-1-andrew@interpretmath.pw> <87d0d0org0.fsf@posteo.net> Date: Fri, 06 Dec 2019 19:34:29 -0600 In-Reply-To: <87d0d0org0.fsf@posteo.net> (Brett Gilio's message of "Fri, 06 Dec 2019 19:27:43 -0600") Message-ID: <878snoor4q.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Andrew Miloradovsky Cc: 38509@debbugs.gnu.org Brett Gilio writes: > Andrew Miloradovsky writes: > >> - (arguments >> - '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc. >> - #:tests? #f)) >> + (arguments '(#:tests? #f)) >> + ;; tests 122-124 (getnameinfo_basic_ip*) fail >> + ;; https://github.com/libuv/libuv/issues/2531 > > Hi Andrew, > > Thank you for your submission. I have some questions before we go > forward with this patch. First, I'd like to note that this change would > trigger a huge rebuild of thousands of dependent packages. > > brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv > Building the following 2067 packages would ensure 5397 dependent packages are rebuilt: > > That said, is there some particular functionality or security that is > provided with this patch? If so, it would be great if you could > elaborate on that in the Git sub-header of the commit message. > > Since this patch would trigger such a massive rebuild it will need to go > to the `core-updates` branch to rest before it sees master. So having > that detail in the commit message will make it easier for us to see what > we are working with. > > Lastly, just curious if there is a way to work around the issues with > tests 122-124 as shown in your above snippet. I know that the tests were > blanket disabled before, so I am just curious if there is a _better_ way > to do this, maybe i'm wrong. If the issue is that the tests require > network functionality that can usually be spoofed with some > effort. Also, stylistically, comments not on the same line as the code > they are commenting usually go before the code in question. > > I hope that makes sense! Let me know if you have any questions, I am > happy to help. Actually, on further exploration of the `core-updates` branch, libuv is already at 1.34 there. -- Brett M. Gilio https://git.sr.ht/~brettgilio/