unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jan Nieuwenhuizen <janneke@gnu.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 38390@debbugs.gnu.org
Subject: [bug#38390] Gash 0.2.0
Date: Mon, 09 Dec 2019 07:37:29 +0100	[thread overview]
Message-ID: <878snmgg2e.fsf@gnu.org> (raw)
In-Reply-To: <877e36v56p.fsf@ngyro.com> (Timothy Sample's message of "Sun, 08 Dec 2019 17:11:10 -0500")

Timothy Sample writes:

Hi Timothy,

>> I just found two things I'm not too happy about.  Both stem from using
>> our bootstrap guile-2.0.9.  Previously, I used guile-2.0 (= 2.0.14) to
>> compile the .go files that were later used during bootstrap.
>
> I did all of my bootstrapping tests with the bootstrap Guile.  I’ve
> attached my package definition for reference (it belongs in
> “commencement.scm”).  The reason I say this is to reassure you that
> going from 2.0.14 to 2.0.9 shouldn’t be too disruptive.

Ah, that's great.

>> then I (of course) still get the Shift/Reduce warnings and everything
>> "seems" to work.  It seems that the empty locale is problematic for
>> guile 2.0.9 or our bootstrap environment.  I just tried a patch and
>> pushed to my wip-0.2.0.
>
> I added (at the last minute) the call to “setlocale” to normalize some
> differences between Guile 2 and Guile 2.2 (I was getting test failures
> without it).  From reading Guile’s NEWS, version 2.2 started
> initializing the locale automatically, so I “backported” that to Guile 2
> by calling “setlocale” with an empty string (as discussed in the
> manual).  Anyway, this is definitely my fault!  Perhaps it should try
> that and then fall back on “(setlocale LC_ALL "C")” if there is a
> problem.  I’ll figure it out before releasing.

OK, thanks.

>> I am less cheerful about the Shift/Reduce warnings; I am afraid they
>> might break something somewhere during the bootstrap build.  Any ideas
>> why these surface at this time?  I'll play some more with
>> lalr.upstream.scm versions...
>
> My understanding is that these are spurious.

That's what I was hoping...although

> There is upstream commit
> 92b64f9b3c02b0086a4aea7cbe7dc38376768150 which is not included in Guile
> 2.0.9 but included in later versions (maybe starting with 2.0.10 – I
> don’t recall).  The commit message is “No more unexpected shift-reduce
> conflicts with LR driver.”  See <https://github.com/schemeway/lalr-scm>.
> Since the newer versions are fine with the parser, and I have parsed
> oodles of shell script using Guile 2.0.9, I think the these warnings are
> just the result of a bug.  :)

...if something in our bootstrap build is asserting that stderr is
empty, they might break on these spurious warnings?

Would it be a good idea to include this fixed lalr when the guile
version is too old?  Note that in the bootstrap build, I am using
the `guile-build-system' (no sh or make yet when bootstrapping our first
gash :-).

> -- Tim
>
> (define gash-boot

Ah, nice; thanks.

Greetings,
janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

      reply	other threads:[~2019-12-09  6:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87muc8g68f.fsf@ngyro.com>
     [not found] ` <87eexk1mag.fsf@gnu.org>
     [not found]   ` <878snped7a.fsf@ngyro.com>
     [not found]     ` <87tv6bv9ds.fsf@ngyro.com>
2019-12-08 20:08       ` [bug#38390] Gash 0.2.0 Jan Nieuwenhuizen
2019-12-08 22:11         ` Timothy Sample
2019-12-09  6:37           ` Jan Nieuwenhuizen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878snmgg2e.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=38390@debbugs.gnu.org \
    --cc=samplet@ngyro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).