unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 38827@debbugs.gnu.org, Reza Alizadeh Majd <r.majd@pantherx.org>
Subject: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Wed, 01 Jan 2020 00:54:37 +0100	[thread overview]
Message-ID: <878smsxd8i.fsf@gnu.org> (raw)
In-Reply-To: <87tv5ga341.fsf@gmail.com> (Mathieu Othacehe's message of "Tue, 31 Dec 2019 17:09:34 +0100")

Hello!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

>> I update the package definition following the above guidelines.
>> could you please check if this updated patch is acceptable?
>
> I fixed the indentation, added one space between the two description
> sentences and pushed.

The ‘vendor’ directory contains a large number of bundled dependencies,
including various bits of Docker and Kubernetes.  I’m not comfortable
keeping this package as is.

Reza, could you look into unbundling these, or at least a significant
part of these?

There’s a Go importer at
<https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00301.html>,
but it’s for ‘Gopkg.toml’ files, which seem to be out of fashion, so I’m
not sure it’d be useful.

In the meantime, I’d be in favor of reverting the patch.  WDYT?

Thanks,
Ludo’.

  reply	other threads:[~2019-12-31 23:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31  9:17 [bug#38827] [PATCH] gnu: Add gitlab-runner Reza Alizadeh Majd
2019-12-31 11:06 ` Mathieu Othacehe
2019-12-31 13:21   ` Reza Alizadeh Majd
2019-12-31 13:42     ` Mathieu Othacehe
2019-12-31 15:48       ` Reza Alizadeh Majd
2019-12-31 16:09         ` Mathieu Othacehe
2019-12-31 23:54           ` Ludovic Courtès [this message]
2020-01-01 12:20             ` Efraim Flashner
2020-01-01 18:58             ` Mathieu Othacehe
2020-01-01 23:22             ` r.majd
2019-12-31 16:09         ` bug#38827: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878smsxd8i.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=38827@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    --cc=r.majd@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).