unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>
Cc: 39384@debbugs.gnu.org
Subject: [bug#39384] [PATCH] gnu: Add emacs-rg.
Date: Sat, 01 Feb 2020 23:09:19 +0100	[thread overview]
Message-ID: <878slmc640.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87v9oqrr0q.fsf@lafreniere.xyz> (Joseph LaFreniere's message of "Sat, 01 Feb 2020 14:28:37 -0600")

Hello,

"LaFreniere, Joseph" <joseph@lafreniere.xyz> writes:

> Patch file is attached to package https://github.com/dajva/rg.el.git.

Thank you! Some comments follow.

> +       (sha256
> +        (base32
> +         "0k7x5z7mh9flwih35cqy8chs54rack3nswdcpw5wcpgv6xim227y"))))

Nitpick: I think the trend is to align `base32' with the string.

> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-s" ,emacs-s)
> +       ("emacs-wgrep" ,emacs-wgrep)
> +       ("ripgrep" ,ripgrep)))
> +    (home-page "https://rgel.readthedocs.io/en/latest/")
> +    (synopsis "A search tool based on @code{ripgrep}")

You may want to lint your package. In particular, the synopsis should be
akin to "Search tool based ..."

> +    (description
> +     "An Emacs search package based on the @code{ripgrep} command line

The description must start with a full sentence, e.g., "rg.el" is an
Emacs search package...

> +tool. It allows you to interactively create searches, doing automatic searches

Texinfo requires two spaces after the full stop.

> +based on the editing context, refining and modifying search results and much
> +more. It is also highly configurable to be able to fit different users’

Ditto. Besides, the quote after "users" looks suspicious. You should use
a regular quote.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2020-02-01 22:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01 20:28 [bug#39384] [PATCH] gnu: Add emacs-rg LaFreniere, Joseph
2020-02-01 22:09 ` Nicolas Goaziou [this message]
2020-02-02 14:21   ` LaFreniere, Joseph
2020-02-02 18:47     ` Efraim Flashner
2020-02-03  3:41       ` LaFreniere, Joseph
2020-02-04  9:58         ` Efraim Flashner
2020-02-05  3:08           ` LaFreniere, Joseph
2020-02-05  7:13             ` Efraim Flashner
2020-02-05 21:33             ` Marius Bakke
2020-02-07  0:47               ` LaFreniere, Joseph
2020-02-07 10:54                 ` Efraim Flashner
2020-02-08 22:23                   ` LaFreniere, Joseph
2020-02-09 13:28                     ` Efraim Flashner
2020-02-22 23:08                       ` LaFreniere, Joseph
2020-02-23 11:17                         ` bug#39384: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878slmc640.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=39384@debbugs.gnu.org \
    --cc=joseph@lafreniere.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).