From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36453) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jK2hH-0006zT-Ha for guix-patches@gnu.org; Thu, 02 Apr 2020 12:28:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jK2hG-00032m-HL for guix-patches@gnu.org; Thu, 02 Apr 2020 12:28:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jK2hG-000320-B4 for guix-patches@gnu.org; Thu, 02 Apr 2020 12:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jK2hG-0007tf-8U for guix-patches@gnu.org; Thu, 02 Apr 2020 12:28:02 -0400 Subject: bug#40211: [PATCH 0/2] Enable udev support in SDL2 and bump version Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <87tv2dc0gw.fsf@araneo.si> References: <87tv2dc0gw.fsf@araneo.si> Date: Thu, 02 Apr 2020 18:27:30 +0200 Message-ID: <878sjdsvil.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Timotej Lazar , 40211-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timotej, Timotej Lazar writes: > Hi, > > these patches update sdl2 to the latest release and enable udev support. > Without udev I experienced freezes every few seconds in certain games > (for instance hedgewars and supertux) as SDL searched through /dev/input > for joysticks. > > Since libudev is dlopened, I add it to rpath in make-flags. During build > this overrides LDFLAGS from the base package=E2=80=99s configure-flags, w= hich > add mesa to rpath. AFAICT this is OK as sdl2 already includes mesa by > linking libgbm. > > (Perhaps we could move LDFLAGS to make-flags in the base package, and > make the override explicit in the derived package? Or have sdl2 find and > modify the LDFLAGS entry from the base configure-flags, but that seems > more trouble than it=E2=80=99s worth.) > > I was able to rebuild all dependent packages with no (new) failures. I > ran several games and everything appears OK, but I don=E2=80=99t have a j= oystick > or gamepad to try. > > There have been some issues in the past with SDL not finding (correct) > libraries=C2=B9, so it would be good to test this on a foreign Guix insta= ll. > As for the version bump, the changelog=C2=B2 doesn=E2=80=99t mention any = significant > changes except for hidapi support, which is disabled by default. Thank you for the excellent research, bugfix, and patches. I have applied both and hope that it will fix a longstanding problem with SuperTuxKart and multiple gamepads that I will try out hopefully this weekend. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6GEnIACgkQoqBt8qM6 VPpRIAgAwY6EM2qc0BYXTftuMViG0e0RTQ4oQCODnNdyjuaxDRuMte68s8i+oXm4 Pu9hAQftK8g9bPFvqGVxxRQj/X6Em+lDSdY29MDoZ4AP8vaO1VPJS3FkQuRGrjbF PiEktTHpZH+iQNHq53X8BPj0XbazShjwxc4e904l5QE0nUYOg3Q4i++ZH6/Zif8C YvFHXtYb3fvyQ21hq0Nb0kiNzBNu/fUACO2c4eDn5nh89k17rrnZDBPIPtM9tqlY 7pjtOHcrOnILzj0H3irvOlAq/8Up4Q2sUXWFa7IvQdkVoNY3GG3VcyiTcRPZzngD VfZHQhOtwFeoQh+D2aSM1a5k0uzndQ== =PEqQ -----END PGP SIGNATURE----- --=-=-=--