unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: maxim.cournoyer@gmail.com
To: maxim.cournoyer@gmail.com
Cc: Raghav Gururajan <raghavgururajan@disroot.org>,
	Mathieu Othacehe <m.othacehe@gmail.com>,
	40445-done@debbugs.gnu.org
Subject: bug#40445: gnu: gsm: Update to 1.0.19.
Date: Sun, 05 Apr 2020 14:20:56 -0400	[thread overview]
Message-ID: <878sj93ibb.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87blo53k9r.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me> (maxim cournoyer's message of "Sun, 05 Apr 2020 13:38:40 -0400")

Hi all,

maxim.cournoyer@gmail.com writes:

> Hello,
>
> "Raghav Gururajan" <raghavgururajan@disroot.org> writes:
>
>> Hi Mathieu!
>>
>>>> + #:make-flags
>>>> + (list
>>>> + ;; Added -fPIC with other default options.
>>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>>> 
>>> I wonder if we need all those options, the package seems to build fine
>>> without them. Could you have a look?
>>
>> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
>>
>> Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>>
>> Regards,
>> RG.
>
> Ooops.  Sorry about that.  I meant:
>
> -       #:make-flags '("INSTALL_ROOT=%output"
> -                      "CCFLAGS=-fPIC \
> +       #:make-flags (list (string-append "INSTALL_ROOT=" %output)
> +                          "CCFLAGS=-fPIC \
>
> But I'll take into accounts comments from Mathieu, which make sense.
>
> Maxim

I've fixed the breakage I caused with commit
5b05f8e9654ea722270c45c0fd0eead369bc0daf, and committed the update to
gsm 1.0.19 from Raghav on top as
5e16e4401f854d39f5fbebaf247750e554bd4a09.

Closing.

Thanks for the ideas!

Maxim

      reply	other threads:[~2020-04-05 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05  7:07 [bug#40445] gnu: gsm: Update to 1.0.19 Raghav Gururajan
2020-04-05  9:40 ` Mathieu Othacehe
2020-04-05  9:45 ` Raghav Gururajan
2020-04-05 10:22   ` Mathieu Othacehe
2020-04-05 10:26   ` Raghav Gururajan
2020-04-05 10:28   ` Raghav Gururajan
2020-04-05 10:33     ` Mathieu Othacehe
2020-04-05 10:37     ` Raghav Gururajan
2020-04-05 10:52     ` Raghav Gururajan
2020-04-05 10:53     ` Raghav Gururajan
2020-04-05 17:38   ` maxim.cournoyer
2020-04-05 18:20     ` maxim.cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sj93ibb.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me \
    --to=maxim.cournoyer@gmail.com \
    --cc=40445-done@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).