From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Elais Player <elais@fastmail.com>
Cc: 40970@debbugs.gnu.org
Subject: [bug#40970] [PATCH] gnu: add emacs-boon
Date: Fri, 01 May 2020 22:49:09 +0200 [thread overview]
Message-ID: <878sib8jp6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <MJCK9Q.9GY8EBVY4BEJ@fastmail.com> (Elais Player's message of "Wed, 29 Apr 2020 12:54:58 -0600")
Hello,
Elais Player <elais@fastmail.com> writes:
> This patch adds the emacs-boon package with changes recommended by
> Nicolas Goaziou.
Thank you.
> + (description
> + "Boon is a complete package for modal editing, which is not Evil.
> +Strong points:
Nitpick: I suggest to use a complete sentence here.
> +@itemize
> +@item Ergonomic: common commands are easy to type.
> +@item Emacs-friendly: Emacs conventions are respected as much as compatible
> +with design goals. This means that Boon integrates well with existing Emacs
> +infrastructure, and leverages it. Existing user configuration can often be
> +re-used.
> +@item Modular: No need to buy into the whole system: mix-and-match the parts
"No need" -> "no need"
Also, you need to put two spaces at the end of sentences in description.
Otherwise, LGTM.
You generated a new patch on top of the previous one. Could you merge
both, fix the above, and send one last patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-01 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 18:54 [bug#40970] [PATCH] gnu: add emacs-boon Elais Player
2020-05-01 20:49 ` Nicolas Goaziou [this message]
2020-11-16 19:22 ` bug#40970: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sib8jp6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40970@debbugs.gnu.org \
--cc=elais@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).