swedebugia writes: > Hi! > > Thanks for the patch. > > On 2019-08-03 06:16, LaFreniere, Joseph wrote: >> I have squashed the fixup into the original commit and rebased on >> current master (82ebb785f178d8618d39b658932d23d9f859fc91). The >> resulting commit is attached. >> >> >> -- Joseph LaFreniere > > Git said this: > > $ git apply 0001-gnu-Add-emacs-hyperbole.patch > 0001-gnu-Add-emacs-hyperbole.patch:122: space before tab in indent. >      (or (and (boundp 'user-mail-address) > 0001-gnu-Add-emacs-hyperbole.patch:123: trailing whitespace. > -- > 0001-gnu-Add-emacs-hyperbole.patch:149: trailing whitespace. > > 0001-gnu-Add-emacs-hyperbole.patch:155: space before tab in indent. >    (dname (or (and (boundp 'message-user-fqdn) > (stringp message-user-fqdn) > 0001-gnu-Add-emacs-hyperbole.patch:156: space before tab in indent. >        (string-match "\\." message-user-fqdn) > warning: squelched 10 whitespace errors > warning: 15 lines add whitespace errors. > > --- > > Could you take a look at that? I took a look at this. Regarding "trailing whitespace", I think those are generated with trailing whitespace in them, so I think it is normal that when adding .patch files to git that we'd see that message. Regarding "space before tab in indent", a mixture of tabs and spaces appears to be consistent with the Hyperbole codebase, so I think that's ok too. Attached is a patch that should apply against master. I have tested it a bit, by going through some of the Hyperbole demo. Things like Koutliner and Hycontrol seem to work, though I did not test all of Hyperbole's many features.