From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CJ+DKpMtyV67JQAA0tVLHw (envelope-from ) for ; Sat, 23 May 2020 14:05:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0IxoJpMtyV7VMAAAB5/wlQ (envelope-from ) for ; Sat, 23 May 2020 14:05:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CF859404CA for ; Sat, 23 May 2020 14:05:07 +0000 (UTC) Received: from localhost ([::1]:35058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUlu-0002eM-49 for larch@yhetil.org; Sat, 23 May 2020 10:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcUlq-0002e2-Iu for guix-patches@gnu.org; Sat, 23 May 2020 10:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcUlq-0004Bk-9b for guix-patches@gnu.org; Sat, 23 May 2020 10:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcUlq-0001O4-4u for guix-patches@gnu.org; Sat, 23 May 2020 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH 03/12] gnu: java-openjfx-graphics: Implement a complete compilation. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 May 2020 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Cc: 41360@debbugs.gnu.org Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.15902426945314 (code B ref 41360); Sat, 23 May 2020 14:05:02 +0000 Received: (at 41360) by debbugs.gnu.org; 23 May 2020 14:04:54 +0000 Received: from localhost ([127.0.0.1]:35224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUlW-0001NS-2r for submit@debbugs.gnu.org; Sat, 23 May 2020 10:04:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUlR-0001NC-6c for 41360@debbugs.gnu.org; Sat, 23 May 2020 10:04:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43453) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUlL-00043I-Ry; Sat, 23 May 2020 10:04:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52238 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcUlL-0007I1-Bl; Sat, 23 May 2020 10:04:31 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200517135138.1651512-1-levenson@mmer.org> <20200517135138.1651512-3-levenson@mmer.org> Date: Sat, 23 May 2020 16:04:29 +0200 In-Reply-To: <20200517135138.1651512-3-levenson@mmer.org> (Alexey Abramov's message of "Sun, 17 May 2020 15:51:32 +0200") Message-ID: <878shi7no2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 7RJnG5u9ryEd Alexey Abramov skribis: > --- > gnu/packages/java.scm | 643 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 635 insertions(+), 8 deletions(-) Please add a commit log. > + (java-aux-class? > + (lambda (class) > + (string-match "\\$[0-9]+.class" class))) Probably =E2=80=9C\\.class=E2=80=9D instead of =E2=80=9C.class=E2=80=9D? > + (add-after 'chdir-to-a-module-directory 'compile-prism-compil= ers > + (lambda _ Maybe add a comment explaining why this phase is necessary. > + (let ((prism-compilers-classes "build/classes/jsl-compile= rs/prism") > + (prism-src "src/main/jsl-prism/")) > + (mkdir-p prism-compilers-classes) > + (apply invoke `("javac" > + "-d" ,prism-compilers-classes > + ,@javac/h-flags > + ,@(find-files prism-src "\\.java")))) This can be shortened as: (apply invoke "javac" "-d" prism-compilers-classes (append javac/h-flags (find-files prism-src "\\.java"))) These two comments apply to the other phases too. More generally, why are there so many phases? How do people normally build it? Gradle? Would it make sense to factorize helpers in a new (gnu build java-openjfx) module or similar? Thanks, Ludo=E2=80=99.