[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[Jonathan Brielmaier]

Thunderbird upstream doesn't provide any desktop file. So we have
to create it downstream. I filed an upstream bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1637575

* gnu/packages/gnuzilla.scm (icedove)[phases]: Add install-desktop-file phase.
---
 gnu/packages/gnuzilla.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 8a926681e0..7bf9850e97 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1344,6 +1344,32 @@ standards of the IceCat project.")
            (lambda _ (invoke "./mach" "build")))
          (replace 'install
            (lambda _ (invoke "./mach" "install")))
+         ;; Thunderbird doesn't provide any .desktop file.
+         ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
+         (add-after 'install 'install-desktop-file
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (apps (string-append out "/share/applications")))
+               (mkdir-p apps)
+               (with-output-to-file (string-append apps "/icedove.desktop")
+                 (lambda _
+                   (format #t
+                           "[Desktop Entry]~@
+                            Name=Icedove~@
+                            Exec=~a/bin/icedove~@
+                            Icon=icedove~@
+                            GenericName=Mail/News Client~@
+                            Categories=Network;Email;~@
+                            Terminal=false~@
+                            StartupNotify=true~@
+                            MimeType=x-scheme-handler/mailto;~@
+                            Type=Application~@
+                            Actions=ComposeMessage;~@
+                            [Desktop Action ComposeMessage]~@
+                            Name=Write new message~@
+                            Exec=~@*~a/bin/icedove -compose~%"
+                           out))))
+             #t))
          (add-after 'install 'wrap-program
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
--
2.26.2

[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[Ricardo Wurmus via web]

This looks good to me!

[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[Jonathan Brielmaier]

so is this good for push? I cannot do that myself.

On 14.05.20 14:50, Ricardo Wurmus via web wrote:
> This looks good to me!
>
>
>
>

bug#41256: [PATCH] gnu: icedove: Add a desktop file.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:

> Thunderbird upstream doesn't provide any desktop file. So we have
> to create it downstream. I filed an upstream bug:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
>
> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add install-desktop-file phase.

Applied, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[Nicolas Goaziou]

Hello,

Marius Bakke <mbakke@fastmail.com> writes:

> Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:
>
>> Thunderbird upstream doesn't provide any desktop file. So we have
>> to create it downstream. I filed an upstream bug:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
>>
>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add
>> install-desktop-file phase.

I'm a bit late at the party, but would it make sense to use
make-desktop-entry-file instead?

Regards,

-- 
Nicolas Goaziou

[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:
>>
>>> Thunderbird upstream doesn't provide any desktop file. So we have
>>> to create it downstream. I filed an upstream bug:
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
>>>
>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add
>>> install-desktop-file phase.
>
> I'm a bit late at the party, but would it make sense to use
> make-desktop-entry-file instead?

Probably, yes.  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#41256] [PATCH] gnu: icedove: Add a desktop file.

[Jonathan Brielmaier]

On 23.05.20 21:56, Nicolas Goaziou wrote:
>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add
>>> install-desktop-file phase.
>
> I'm a bit late at the party, but would it make sense to use
> make-desktop-entry-file instead?
Oh Nicolas that is a good catch. I didn't know this nice function :P

But I wonder how to archive the compose action:
```
[Desktop Action ComposeMessage]~@
Name=Write new message~@
Exec=~@*~a/bin/icedove -compose~%"
```

With the field `actions` but how?