From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6FCnJC4JUl9iLgAA0tVLHw (envelope-from ) for ; Fri, 04 Sep 2020 09:30:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WLiIIC4JUl9mIAAAbx9fmQ (envelope-from ) for ; Fri, 04 Sep 2020 09:30:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1ED529402CB for ; Fri, 4 Sep 2020 09:30:22 +0000 (UTC) Received: from localhost ([::1]:60694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE833-0006qj-37 for larch@yhetil.org; Fri, 04 Sep 2020 05:30:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE82k-0006Pg-MV for guix-patches@gnu.org; Fri, 04 Sep 2020 05:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kE82k-0005Nh-Cc for guix-patches@gnu.org; Fri, 04 Sep 2020 05:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kE82k-00010r-5T for guix-patches@gnu.org; Fri, 04 Sep 2020 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43198] Add breeze icon assets Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Sep 2020 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43198 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Prafulla Giri Cc: 43198@debbugs.gnu.org Received: via spool by 43198-submit@debbugs.gnu.org id=B43198.15992117723830 (code B ref 43198); Fri, 04 Sep 2020 09:30:02 +0000 Received: (at 43198) by debbugs.gnu.org; 4 Sep 2020 09:29:32 +0000 Received: from localhost ([127.0.0.1]:37450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE82F-0000zi-Nh for submit@debbugs.gnu.org; Fri, 04 Sep 2020 05:29:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE82D-0000zS-B4 for 43198@debbugs.gnu.org; Fri, 04 Sep 2020 05:29:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57779) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE828-0005K0-2o; Fri, 04 Sep 2020 05:29:24 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46488 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE827-0007zz-4E; Fri, 04 Sep 2020 05:29:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 04 Sep 2020 11:29:17 +0200 In-Reply-To: (Prafulla Giri's message of "Fri, 4 Sep 2020 14:07:27 +0545") Message-ID: <878sdpvqj6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: BAiVEJmbJkp2 Hi, Prafulla Giri skribis: > From ac4c48493cff931d8f04abf8f52236e49bc818ae Mon Sep 17 00:00:00 2001 > From: Prafulla Giri > Date: Fri, 4 Sep 2020 12:56:26 +0545 > Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets > > * gnu/packages/kde-frameworks.scm (breeze-assets): New variable. [...] > +(define-public breeze-assets > + (package (inherit breeze-icons) > + (name "breeze-assets") Please indent like this: (package (inherit breeze-icons) (name =E2=80=A6) =E2=80=A6) > + (synopsis "Artwork, styles and assets for the Breeze visual s= tyle") > + (description "Artwork, styles and assets associated with the = Breeze > +visual style.") Please write full sentences for the description: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > + (license license:gpl2))) Is it GPL-version-2-only? That=E2=80=99d mean that source file headers (or similar) explicitly omit the =E2=80=9Cor any later version=E2=80=9D wording. > From 468f64cd140bf38b6142fa0e4e1d6cae22c2b8df Mon Sep 17 00:00:00 2001 > From: Prafulla Giri > Date: Fri, 4 Sep 2020 12:59:28 +0545 > Subject: [PATCH 2/2] gnu: kde-frameworks: Add breeze > > * gnu/packages/kde-frameworks.scm (breeze): New variable. > --- > gnu/packages/kde-frameworks.scm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-framework= s.scm > index 7fd17d92b7..2ff90fb915 100644 > --- a/gnu/packages/kde-frameworks.scm > +++ b/gnu/packages/kde-frameworks.scm > @@ -355,6 +355,20 @@ It is the default icon theme for the KDE Plasma 5 de= sktop.") > visual style.") > (license license:gpl2))) >=20=20 > +(define-public breeze > + (package (inherit (@ (gnu packages mate) mate)) ;; union-build boilerp= late > + (name "breeze") In general, use of =E2=80=98@=E2=80=99 must be avoided: it=E2=80=99s better= to just import the modules you need. More importantly though, you must not inherit from a package defined in another module as that would prevent modules from being loaded. The solution here is probably to duplicate all the fields instead of inheriting. In this case, that=E2=80=99s probably not going to be much lon= ger anyway. And if you want, you can add a comment saying that breeze is based on MATE or something. HTH! Thank you, Ludo=E2=80=99.