From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 1eSYOZyCWF/bSwAA0tVLHw (envelope-from ) for ; Wed, 09 Sep 2020 07:22:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MFgpNZyCWF90ZgAA1q6Kng (envelope-from ) for ; Wed, 09 Sep 2020 07:22:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F3C89402A2 for ; Wed, 9 Sep 2020 07:22:04 +0000 (UTC) Received: from localhost ([::1]:52680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFuQd-0003TC-7V for larch@yhetil.org; Wed, 09 Sep 2020 03:22:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFuPe-0002l3-TU for guix-patches@gnu.org; Wed, 09 Sep 2020 03:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFuPe-0005B8-Jx for guix-patches@gnu.org; Wed, 09 Sep 2020 03:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFuPe-0001aU-FL for guix-patches@gnu.org; Wed, 09 Sep 2020 03:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42380] [PATCH] gnu: Add torbrowser-unbundle. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Sep 2020 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42380 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Andr=C3=A9?= Batista Cc: Efraim Flashner , 42380@debbugs.gnu.org Received: via spool by 42380-submit@debbugs.gnu.org id=B42380.15996360246035 (code B ref 42380); Wed, 09 Sep 2020 07:21:02 +0000 Received: (at 42380) by debbugs.gnu.org; 9 Sep 2020 07:20:24 +0000 Received: from localhost ([127.0.0.1]:56990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFuP2-0001ZH-3j for submit@debbugs.gnu.org; Wed, 09 Sep 2020 03:20:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFuOy-0001Z1-O2 for 42380@debbugs.gnu.org; Wed, 09 Sep 2020 03:20:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57108) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFuOt-0004yE-BN; Wed, 09 Sep 2020 03:20:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54450 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFuOs-0005Q8-Qu; Wed, 09 Sep 2020 03:20:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200715211547.GA17146@andel> <20200725144930.GA13751@andel> <20200803125556.GA18868@andel> <87blihhdz6.fsf@gnu.org> <20200909022429.GA24930@andel> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 09 Sep 2020 09:20:08 +0200 In-Reply-To: <20200909022429.GA24930@andel> ("=?UTF-8?Q?Andr=C3=A9?= Batista"'s message of "Tue, 8 Sep 2020 23:24:29 -0300") Message-ID: <878sdjo1qv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ahl9NbF9w1oe Hi Andr=C3=A9, Andr=C3=A9 Batista skribis: > Just a small token of my appreciation for your years of work on > guix. I'm glad to be able to give something back to this community. Thank you. > I've been using this package for the last month or so and did not > hit any bugs so, though I'm not a heavy web user, I think it's fair > to say the result is functional. > > On the down side, the https-everywhere extension is broken as is > since it's missing lib-wasm. I've built but did not send here a > version which just copies lib-wasm to its proper place before > building the extension and this version works without further > issues. > > The reason I did not send it to this list is that lib-wasm source > provides a precompiled prepackaged file[1] which is then used on > https-everywhere build script and it's source code is not actualy > compiled[2]. As I understand it, the Tor Project just relies on > this precompiled binary on its build procedure and the same seems > to be true for IceCat[3][4]. Oh, glad that you were able to identify that issue, which presumably had been overlooked so far. > In order to have everything compiled from source, I've had to > define a lot of rust libs which were required for building > wasm-pack and then to have a rustc with wasm32-unknown-unknown > target enabled and compatible with wasm-pack (apparently newer > versions changed compiler strings and wasm-pack errors out when > trying to parse). For over two weeks I've been trying without > success and always thinking that the next build would succeed. > > Long story short, maybe there's just one more issue pending when > compiling lib-wasm. When wasm-pack is invoked, everything > compiles but I'm getting the following error: > > note: lld: error: /gnu/store/kwdsf42z7ib6fr5vggqi9nc4jpi1znxy-rust-1.38.0= /lib/rustlib/wasm32-unknown-unknown/lib/libstd-373ca16e620a2f9a.rlib: archi= ve has no index; run ranlib to add one > > for a few rust libs. Without lld, it complains about a missing > rust-lld binary. Also, this appears to be the rust standard > nowadays[5]. Ah. I=E2=80=99m Cc=E2=80=99ing Efraim, who=E2=80=99s been very much into R= ust packaging for some time; does that ring a bell, Efraim? > If I'm not terribly wrong, this issue[6] seems to suggest an > approach for emscripten which could solve this issue without > removing the 'strip' phase which was the work around suggested > by some on the same thread. > > Another issue that is pending is that libwasm depends on rust > multi-default-trait-impl crate. This crate defines lgpl2.1+ on > its Cargo.toml file, but the sources does not contain neither a > copy of the license. So I'm unsure if this is enough to make it > free software. So I'm planning on sending some mails to both the > maintainer and FSF to see if this needs improvement. Great. >> For the final submission, we=E2=80=99d need one patch per new package, a= s is >> customary. That will have the advantage of allowing review to proceed >> one bit at a time. :-) > > For sure. I'll give it a few more tries and cleanup the mess > here before sending this patch series. If I don't succeed, I'm > planning on sending it anyway so at least the libs can be > added and maybe someone can spot what I'm missing. But maybe > it's wise to hold Tor Browser itself since there has been an > announcement of some large percentage of exit relays messing > with Tor traffic[7]. I don=E2=80=99t think Guix users will radically increase traffic over Tor, = so I think we can keep going. :-) >> Regarding Tor Browser itself, can you think of ways to factorize code >> with IceCat? > > Other than sharing the https-everywhere definition, I was > thinking maybe we could take a diff of Tor Browser and Firefox > and avoid downloading firefox source twice when building both > browsers. But I need to take a more careful look. I'll give > this question some thought. OK. I was expecting at least things like some of the build phases and most/all of the inputs to be the same, but I haven=E2=80=99t checked. Thanks again for all the work! Ludo=E2=80=99.