From: "Ludovic Courtès" <ludo@gnu.org>
To: "André Batista" <nandre@riseup.net>
Cc: Efraim Flashner <efraim@flashner.co.il>, 42380@debbugs.gnu.org
Subject: [bug#42380] [PATCH] gnu: Add torbrowser-unbundle.
Date: Wed, 09 Sep 2020 09:20:08 +0200 [thread overview]
Message-ID: <878sdjo1qv.fsf@gnu.org> (raw)
In-Reply-To: <20200909022429.GA24930@andel> ("André Batista"'s message of "Tue, 8 Sep 2020 23:24:29 -0300")
Hi André,
André Batista <nandre@riseup.net> skribis:
> Just a small token of my appreciation for your years of work on
> guix. I'm glad to be able to give something back to this community.
Thank you.
> I've been using this package for the last month or so and did not
> hit any bugs so, though I'm not a heavy web user, I think it's fair
> to say the result is functional.
>
> On the down side, the https-everywhere extension is broken as is
> since it's missing lib-wasm. I've built but did not send here a
> version which just copies lib-wasm to its proper place before
> building the extension and this version works without further
> issues.
>
> The reason I did not send it to this list is that lib-wasm source
> provides a precompiled prepackaged file[1] which is then used on
> https-everywhere build script and it's source code is not actualy
> compiled[2]. As I understand it, the Tor Project just relies on
> this precompiled binary on its build procedure and the same seems
> to be true for IceCat[3][4].
Oh, glad that you were able to identify that issue, which presumably had
been overlooked so far.
> In order to have everything compiled from source, I've had to
> define a lot of rust libs which were required for building
> wasm-pack and then to have a rustc with wasm32-unknown-unknown
> target enabled and compatible with wasm-pack (apparently newer
> versions changed compiler strings and wasm-pack errors out when
> trying to parse). For over two weeks I've been trying without
> success and always thinking that the next build would succeed.
>
> Long story short, maybe there's just one more issue pending when
> compiling lib-wasm. When wasm-pack is invoked, everything
> compiles but I'm getting the following error:
>
> note: lld: error: /gnu/store/kwdsf42z7ib6fr5vggqi9nc4jpi1znxy-rust-1.38.0/lib/rustlib/wasm32-unknown-unknown/lib/libstd-373ca16e620a2f9a.rlib: archive has no index; run ranlib to add one
>
> for a few rust libs. Without lld, it complains about a missing
> rust-lld binary. Also, this appears to be the rust standard
> nowadays[5].
Ah. I’m Cc’ing Efraim, who’s been very much into Rust packaging for
some time; does that ring a bell, Efraim?
> If I'm not terribly wrong, this issue[6] seems to suggest an
> approach for emscripten which could solve this issue without
> removing the 'strip' phase which was the work around suggested
> by some on the same thread.
>
> Another issue that is pending is that libwasm depends on rust
> multi-default-trait-impl crate. This crate defines lgpl2.1+ on
> its Cargo.toml file, but the sources does not contain neither a
> copy of the license. So I'm unsure if this is enough to make it
> free software. So I'm planning on sending some mails to both the
> maintainer and FSF to see if this needs improvement.
Great.
>> For the final submission, we’d need one patch per new package, as is
>> customary. That will have the advantage of allowing review to proceed
>> one bit at a time. :-)
>
> For sure. I'll give it a few more tries and cleanup the mess
> here before sending this patch series. If I don't succeed, I'm
> planning on sending it anyway so at least the libs can be
> added and maybe someone can spot what I'm missing. But maybe
> it's wise to hold Tor Browser itself since there has been an
> announcement of some large percentage of exit relays messing
> with Tor traffic[7].
I don’t think Guix users will radically increase traffic over Tor, so I
think we can keep going. :-)
>> Regarding Tor Browser itself, can you think of ways to factorize code
>> with IceCat?
>
> Other than sharing the https-everywhere definition, I was
> thinking maybe we could take a diff of Tor Browser and Firefox
> and avoid downloading firefox source twice when building both
> browsers. But I need to take a more careful look. I'll give
> this question some thought.
OK. I was expecting at least things like some of the build phases and
most/all of the inputs to be the same, but I haven’t checked.
Thanks again for all the work!
Ludo’.
next prev parent reply other threads:[~2020-09-09 7:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 21:15 [bug#42380] [WIP] gnu: Add torbrowser-unbundle André Batista
2020-07-25 14:49 ` [bug#42380] [PATCH] " André Batista
2020-08-03 12:55 ` André Batista
2020-09-07 14:13 ` Ludovic Courtès
2020-09-09 2:24 ` André Batista
2020-09-09 7:20 ` Ludovic Courtès [this message]
2020-09-09 10:59 ` Efraim Flashner
2020-09-15 14:21 ` [bug#42380] [PATCH 0/9] " André Batista
2020-09-15 15:01 ` [bug#42380] [PATCH 1/9] gnu: Add go-torproject-org-ptlib André Batista
2020-09-15 15:04 ` [bug#42380] [PATCH 2/9] gnu: Add go-github-com-agl-ed25519 André Batista
2020-09-15 22:50 ` [bug#42380] [PATCH 2v2/9] " André Batista
2020-09-15 15:06 ` [bug#42380] [PATCH 0/9] gnu: Add go-github-com-dchest-siphash André Batista
2020-09-15 22:53 ` [bug#42380] [PATCH 3/9] " André Batista
2020-09-15 15:08 ` [bug#42380] [PATCH 4/9] gnu: Add go-github-com-dchest-uniuri André Batista
2020-09-15 15:10 ` [bug#42380] [PATCH 5/9] gnu: Add go-github-com-dsnet-compress André Batista
2020-09-15 15:12 ` [bug#42380] [PATCH 6/9] gnu: Add go-schwanenlied-me-yawning-bsaes André Batista
2020-09-15 15:14 ` [bug#42380] [PATCH 7/9] gnu: Add go-gitlab-com-yawning-utls André Batista
2020-09-15 15:15 ` [bug#42380] [PATCH 8/9] gnu: obfs4 André Batista
2020-09-15 15:16 ` [bug#42380] [PATCH 9/9] gnu: Add torbrowser-unbundle André Batista
2020-09-24 23:18 ` [bug#42380] [PATCHv2 " André Batista
2020-10-07 15:51 ` [bug#42380] [PATCHv3 " André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 0/9] " André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 1/9] gnu: Add go-torproject-org-ptlib André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 2/9] gnu: Add go-github-com-agl-ed25519 André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 3/9] gnu: Add go-github-com-dchest-siphash André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 4/9] gnu: Add go-github-com-dchest-uniuri André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 5/9] gnu: Add go-github-com-dsnet-compress André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 6/9] gnu: Add go-schwanenlied-me-yawning-bsaes André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 7/9] gnu: Add go-gitlab-com-yawning-utls André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 8/9] gnu: Add obfs4 André Batista
2021-06-03 3:17 ` [bug#42380] [PATCH v4 9/9] gnu: Add torbrowser-unbundle André Batista
2021-06-03 4:10 ` [bug#42380] [PATCH v5 " André Batista
2021-06-03 21:07 ` Maxime Devos
2021-07-10 3:10 ` André Batista
2021-06-03 21:07 ` Maxime Devos
2020-09-12 13:35 ` [bug#42380] Wow! Raghav Gururajan
2020-09-15 15:23 ` André Batista
2021-05-25 15:05 ` Xinglu Chen
2021-05-25 19:12 ` Leo Famulari
2021-05-25 21:24 ` Ludovic Courtès
2021-05-28 1:45 ` André Batista
2021-06-03 20:43 ` Ludovic Courtès
2023-12-12 11:21 ` [bug#42380] [PATCH] gnu: Add torbrowser Clément Lassieur
2023-12-14 21:54 ` André Batista
2023-12-15 17:04 ` André Batista
2023-12-16 3:49 ` André Batista
2023-12-19 18:19 ` Clément Lassieur
2023-12-21 15:05 ` [bug#42380] [WIP] gnu: Add torbrowser-unbundle Clément Lassieur
2023-12-22 14:54 ` André Batista
2023-12-25 15:28 ` Clément Lassieur
2023-12-27 10:03 ` André Batista
2023-12-27 11:18 ` bug#42380: " Clément Lassieur
2023-12-21 13:56 ` [bug#42380] [PATCH v2] gnu: Add torbrowser Clément Lassieur
2023-12-27 21:22 ` [bug#42380] [WIP] gnu: Add torbrowser-unbundle Anonymousemail via Guix-patches via
2023-12-28 16:03 ` Clément Lassieur
2023-12-30 0:34 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sdjo1qv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42380@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=nandre@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).