From: Pierre Langlois <pierre.langlois@gmx.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: Pierre Langlois <pierre.langlois@gmx.com>, 43347-done@debbugs.gnu.org
Subject: bug#43347: [PATCH] services: dovecot: Do not require dovecot to be globally installed.
Date: Fri, 11 Sep 2020 22:50:16 +0100 [thread overview]
Message-ID: <878sdg6l0n.fsf@gmx.com> (raw)
In-Reply-To: <ba844fd0bb0dec2270d63098cd0ec944@tobias.gr>
[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]
Tobias Geerinckx-Rice writes:
> Pierre,
>
> Thank you very much for the bug report.
>
> On 2020-09-11 21:40, Pierre Langlois wrote:
>> I noticed recently my little dovecot mailserver failed to boot, I
>> tracked it down to our service installing a symlink as:
>> /etc/dovecot/modules -> /run/current-system/profile/lib/dovecot
>> However, I didn't have the dovecot package globally installed, the
>> service does not install it AFAICT.
>
> Sorry, this is my fault. I've been slowly merging some Dovecot
> improvements[0] into master.
>
> While I'm happily replying from the latest Dovecot service, I run it
> in an... idiosyncratic manner that had me write some glue code to test
> these patches. I didn't realize that said glue was doing more work
> than I, er, realized. Too much.
No worries! I see you've reverted the commits so I'll close this.
>> We could extend the service to install dovecot into the global profile,
>> however instead we can just symlink /etc/dovecot/modules to the dovecot
>> package in the store directly.
>
> Nack. That just reverts to last week's monolithic Dovecot service
> that doesn't support modules, but now with pointless indirection via
> /etc. Nor should the service add anything to the system profile, or
> expect the user to do so.
>
> The fix is to add a ‘modules’ field to the service configuration that,
> exactly like CUPS's ‘extensions’ field, adds module packages like
> dovecot-pigeonhole to the union directory that /etc/dovecot/modules
> points to.
Ah I see, I wasn't aware of the dovecot modules, the indirection being
pointless with my changes should have been a hint there was something
wrong :-).
Thanks,
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
next prev parent reply other threads:[~2020-09-11 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 19:40 [bug#43347] [PATCH] services: dovecot: Do not require dovecot to be globally installed Pierre Langlois
2020-09-11 21:02 ` Julien Lepiller
2020-09-11 21:33 ` Tobias Geerinckx-Rice via Guix-patches via
2020-09-11 21:50 ` Pierre Langlois [this message]
2020-09-12 15:06 ` Alexey Abramov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sdg6l0n.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=43347-done@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).