From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yJ5HBv63jl/KDwAA0tVLHw (envelope-from ) for ; Tue, 20 Oct 2020 10:12:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +CYRAv63jl+HUgAA1q6Kng (envelope-from ) for ; Tue, 20 Oct 2020 10:12:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 973769404D2 for ; Tue, 20 Oct 2020 10:12:13 +0000 (UTC) Received: from localhost ([::1]:40282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUocm-0000vv-IM for larch@yhetil.org; Tue, 20 Oct 2020 06:12:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUocd-0000vc-H9 for guix-patches@gnu.org; Tue, 20 Oct 2020 06:12:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUocc-0008WO-FV for guix-patches@gnu.org; Tue, 20 Oct 2020 06:12:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUocc-0004KZ-Ai for guix-patches@gnu.org; Tue, 20 Oct 2020 06:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44089] [PATCH] gnu: Add emacs-wucuo. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Oct 2020 10:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44089 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Joseph LaFreniere Cc: 44089@debbugs.gnu.org Received: via spool by 44089-submit@debbugs.gnu.org id=B44089.160318870816624 (code B ref 44089); Tue, 20 Oct 2020 10:12:02 +0000 Received: (at 44089) by debbugs.gnu.org; 20 Oct 2020 10:11:48 +0000 Received: from localhost ([127.0.0.1]:43686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUocO-0004K3-5Q for submit@debbugs.gnu.org; Tue, 20 Oct 2020 06:11:48 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUocM-0004Jp-6n for 44089@debbugs.gnu.org; Tue, 20 Oct 2020 06:11:47 -0400 X-Originating-IP: 176.137.73.130 Received: from localhost (chr13-h03-176-137-73-130.dsl.sta.abo.bbox.fr [176.137.73.130]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 198336001A; Tue, 20 Oct 2020 10:11:38 +0000 (UTC) From: Nicolas Goaziou In-Reply-To: <878sc1k27o.fsf@odyssey.lafreniere.xyz> (Joseph LaFreniere's message of "Mon, 19 Oct 2020 22:26:03 -0500") References: <878sc1k27o.fsf@odyssey.lafreniere.xyz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Tue, 20 Oct 2020 12:11:38 +0200 Message-ID: <878sc18aw5.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 1.0 (+) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: WLcQL96ANFwq Hello, Joseph LaFreniere writes: > Subject: [PATCH] gnu: Add emacs-wucuo. > > * gnu/packages/emacs-xyz.scm (emacs-wucuo): New variable. Thank you. Some comments follow. > + (version "0.2.7") Based on your feedback, upstream released 0.2.8 a few hours ago. > + (sha256 > + (base32 > + "1iw4jdlqvki95gh7bzl7hjidc2kz9qyc1zjd7klh63gvk0z09700")))) Nitpick: please move the string on the same line as `base32'. > + (build-system emacs-build-system) > + (home-page "https://github.com/redguardtoo/wucuo") > + (synopsis > + "Fastest solution to spell check camel case code or plain text") Please move the string on the same line as `synopsis'. Also, "fastest" sounds like a buzzword. I think "Fast" would be more neutral. > + (description > + "This package provides a spell checker on top of either aspell or > +hunspell. > + > +@itemize > +@item @code{wucuo-spell-check-file} will spell check one file and report its > +typos > +@item If @code{wucuo-flyspell-start-mode} is \"normal\", @code{wucuo-start} > +runs @code{flyspell-buffer}. If it's \"normal\", @code{wucuo-start} runs > +@code{flyspell-region} to check visible region in current window. > +@item The interval of checking is set by @code{wucuo-update-interval} > +@end itemize > + > +See @code{wucuo-check-nil-font-face} on how to check plain text (text without > +font) > +@itemize > +@item Use @code{wucuo-current-font-face} to detect font face at point > +@item If @code{wucuo-flyspell-start-mode} is \"normal\", > +@code{wucuo-spell-check-buffer-max} specifies the maximum size of buffer to > +check. If @code{wucuo-flyspell-start-mode} is \"fast\", > +@code{wucuo-spell-check-region-max} specifies the maximum size of visible > +region to check. > +@item You can define a function in @code{wucuo-spell-check-buffer-predicate}. > +If the function returns t, the spell checking of current buffer will continue. > +If it returns nil, the spell checking is skipped. > +@end itemize > + > +Here is sample to skip checking in specified major modes, > +@lisp > + (setq wucuo-spell-check-buffer-predicate > + (lambda () > + (not (memq major-mode > + '(dired-mode > + log-edit-mode > + compilation-mode > + help-mode > + profiler-report-mode > + speedbar-mode > + gud-mode > + calc-mode > + Info-mode))))) > +@end lisp") I think most of this belongs to the manual, not to the description. What about: This package provides a spell checker on top of either Aspell or Hunspell, and relies on Flyspell internally. It operates on the current region or buffer, a file, or a complete directory. Could you send an updated patch? Regards, -- Nicolas Goaziou