From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sIRKMP73hmDMBQAAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 19:27:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QAPNK/73hmBYLQAAbx9fmQ (envelope-from ) for ; Mon, 26 Apr 2021 17:27:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CDEA11D79 for ; Mon, 26 Apr 2021 19:27:26 +0200 (CEST) Received: from localhost ([::1]:51684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb513-0001Qf-Iy for larch@yhetil.org; Mon, 26 Apr 2021 13:27:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb50g-0001PE-Cu for guix-patches@gnu.org; Mon, 26 Apr 2021 13:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lb50g-0007Sc-5H for guix-patches@gnu.org; Mon, 26 Apr 2021 13:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lb50g-0000f5-31 for guix-patches@gnu.org; Mon, 26 Apr 2021 13:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48028] [PATCH wip-gnome v4 3/8] gnu: gtkmm: Add missing native-input and correct propagated-inputs Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Apr 2021 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Raghav Gururajan , Leo Prikler , 48028@debbugs.gnu.org Received: via spool by 48028-submit@debbugs.gnu.org id=B48028.16194579962511 (code B ref 48028); Mon, 26 Apr 2021 17:27:02 +0000 Received: (at 48028) by debbugs.gnu.org; 26 Apr 2021 17:26:36 +0000 Received: from localhost ([127.0.0.1]:47059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb50F-0000eR-WA for submit@debbugs.gnu.org; Mon, 26 Apr 2021 13:26:36 -0400 Received: from world.peace.net ([64.112.178.59]:35790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb50D-0000eD-VI for 48028@debbugs.gnu.org; Mon, 26 Apr 2021 13:26:34 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lb506-0002l5-U3; Mon, 26 Apr 2021 13:26:27 -0400 From: Mark H Weaver In-Reply-To: References: <20210426081145.28926-1-rg@raghavgururajan.name> <20210426081145.28926-5-rg@raghavgururajan.name> <73660fda850714bb152afc392df78addecd29932.camel@student.tugraz.at> <88a82777-3c12-58d6-912f-196ea150f772@raghavgururajan.name> <610e1f33a099e2b8fad8f5df21447f9108082a9c.camel@student.tugraz.at> Date: Mon, 26 Apr 2021 13:26:10 -0400 Message-ID: <878s55j6sy.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 8CDEA11D79 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: iZQ5nBr4Rcwr Hi Raghav, Version 4 of your patch set mostly looks good to me, but I have one concern about patch 3 (gnu: gtkmm: Add missing native-input and correct propagated-inputs). That patch modifies the 'propagated-inputs' field of 'gtkmm' to refer to specific versions of packages: 'atkmm-2.28', 'cairomm-1.13', and 'pangomm-2.42'. These references to specific versions are not ideal, because: (1) They will likely lead to conflicts within profiles. For example, a profile that includes both 'gtkmm' and 'cairomm' may fail to build, because it would require including both 'cairomm' and 'cairomm-1.13', and (2) We might forget to update these references in the future. It would be good to avoid these version-specific references, if possible. Can you help me understand the rationale? Did you find that there is an incompatibility between the latest stable versions of 'gtkmm', 'atkmm', 'cairomm', and 'pangomm'? If so, could you help me understand the nature of that incompatibility? Perhaps it can be addressed in another way. If it turns out that these versioned references are truly unavoidable, it would be good to add comments next to those references, briefly explaining the rationale. Thanks very much for your work on this, Raghav. Regards, Mark -- Support Richard Stallman against the vicious disinformation campaign against him and the FSF. See for more.