From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0CYgIKc+mGDhhwAAgWs5BA (envelope-from ) for ; Sun, 09 May 2021 21:57:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qJ62G6c+mGAYcQAAB5/wlQ (envelope-from ) for ; Sun, 09 May 2021 19:57:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12FC519935 for ; Sun, 9 May 2021 21:57:27 +0200 (CEST) Received: from localhost ([::1]:55408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfpYL-0007os-5e for larch@yhetil.org; Sun, 09 May 2021 15:57:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfpXy-0007oj-E8 for guix-patches@gnu.org; Sun, 09 May 2021 15:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfpXy-0002dm-6Q for guix-patches@gnu.org; Sun, 09 May 2021 15:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lfpXy-0001OK-2l for guix-patches@gnu.org; Sun, 09 May 2021 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48277] [PATCH 0/1] New wrap-in-search-paths function Resent-From: Edouard Klein Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 09 May 2021 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48277 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 48277@debbugs.gnu.org Received: via spool by 48277-submit@debbugs.gnu.org id=B48277.16205902135334 (code B ref 48277); Sun, 09 May 2021 19:57:02 +0000 Received: (at 48277) by debbugs.gnu.org; 9 May 2021 19:56:53 +0000 Received: from localhost ([127.0.0.1]:56658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfpXp-0001Ny-5A for submit@debbugs.gnu.org; Sun, 09 May 2021 15:56:53 -0400 Received: from sender4-op-o10.zoho.com ([136.143.188.10]:17083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfpXj-0001Nk-Cg for 48277@debbugs.gnu.org; Sun, 09 May 2021 15:56:51 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1620590204; cv=none; d=zohomail.com; s=zohoarc; b=mqPK6lp3xZpA0AAoRBebVeyHkVs7hj1UDWVAMKzZJyiSIpZHQOzKeqGOc/rM3Gsofe34Y+wggOSKXSlHJy+fQh/rBa3giyGcf9cQf4ASgzkuaDkNQQkbayTUqJXewlfYK9+QwkaiYdQo3x8/1cAb6Sq/6r6y6CWAFz//VOEWFsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620590204; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lZMNmfBHq6bDNAWSbEgKKiqh3aNSFBDX+obFZZJxNYE=; b=iShp3vxj74w5WR0b5tD19etTXIeyTn117Vz2NQDM+SWcq0JrMKjxwpXsqwLkjIKVNUfsQL7fXTWCX8TqpKyWBVt+kaS/QmWoiBLQ90WejCYaY3tF2cnBXYaAcDS4NM/ts73l+MIrfIJbtj32OszBBHfrTSRPPcftbRgbzXHC+WM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1620590204; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:To:Cc:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type; bh=lZMNmfBHq6bDNAWSbEgKKiqh3aNSFBDX+obFZZJxNYE=; b=gCzZ1Vl1XLsjRXuowP3UJgYfg/LvazrXVg2Ww0Ob0nGTmpEF9StI76i0ig5ikxy3 1Cnl8zEFAVspIp/vcx3ftFDZ4yVDiLNP9iA84eJoX8U/J/AfQHBwp12oh8LvTgV6uhb Wz12yy2m9eIEmhk2rv+6FrMMvJvSZhRQs9GfftZM= Received: from Rasoir (lfbn-idf3-1-808-29.w90-3.abo.wanadoo.fr [90.3.133.29]) by mx.zohomail.com with SMTPS id 1620590201599904.2571976327558; Sun, 9 May 2021 12:56:41 -0700 (PDT) References: <20210507154208.123628-1-edk@beaver-labs.com> <7fa3822a2df127f16b92cfb0a35bf41176073eb7.camel@telenet.be> User-agent: mu4e 1.4.15; emacs 27.2 From: Edouard Klein In-reply-to: <7fa3822a2df127f16b92cfb0a35bf41176073eb7.camel@telenet.be> Message-ID: <878s4nu1ea.fsf@rdklein.fr> Date: Sun, 09 May 2021 21:56:29 +0200 MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620590247; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lZMNmfBHq6bDNAWSbEgKKiqh3aNSFBDX+obFZZJxNYE=; b=t1820G400KKIyy/fqC2e7En6yi8q7taAOpKLMSvmlDbrt9URafRekUzwCNvckvcERy1WBi lCm9iOM3DDadak6pz0MaG/0iEr1vJMgnMG0FeIAiv94zXJS9SmnpPbgVsi8ECPHLQa6nMd hQdu1sCL6Gv7iZJT5yiK2aV7T8Jjm+Zva2iKs4y/dYANIqwH7Z+MHPQ59N0hZUkV534nZh 3nlqyYvpqo27zItcZey1q5+6MA86JhHS2psdWv0K+gLBJyI6ipg5RZ75fCVyGOst7chzXA FUmKlMWL2YLY/xA8sdPzTQYSFshahJjggHEyJwyTy23Eom+s8SP1bVYaaQN66Q== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1620590247; a=rsa-sha256; cv=fail; b=suWgnkTh9jRZtbYKLb8+hcbVNx/vc0ldzNqZHhVF9IeH0RJxqkRmOk30HKZB73JAnGdY/v XKL7kg3wMyx+vPWzJoRDUp1KisNlM9ISEr99ju4+XQqrByV1/LsQOu0Zr2uizLvW6i6ryn /HynVj5NzCm6Zv5DqHuYlQLGtSXLOS05xVga9qK0t9ah8xdoBUo+N99lbUOa+TeEjMi1Qg D/+6k68RPSBXV/qS2WrMcQfTBDi+xm9BeTc0bt324Rsa2spIJnlRLDDjdLGqmQ4lO0039y kGjoq6kLpAq4HeNGuNMK4lNSikJIXeEGsvGRwyPZ7zzrHmaqgKVEgfmtHljP0w== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=rdklein.fr header.s=zoho header.b=gCzZ1Vl1; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.05 Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=rdklein.fr header.s=zoho header.b=gCzZ1Vl1; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 12FC519935 X-Spam-Score: 1.05 X-Migadu-Scanner: scn0.migadu.com X-TUID: yQFwzFz7kuWP Hi, Thanks for reviewing the patch, Good point about the tests. I'll try to send a follow-up patch on this thread with the requested changes to a tested service. Cheers, Edouard. Maxime Devos writes: > Edouard Klein schreef op vr 07-05-2021 om 17:42 [+0200]: >> This patch adds the wrap-in-search-paths function [...]. >> [... text about shepherd services, foreign distros, propagated-inputs, >> gexps ...] > > I don't see any obvious problems with the patch, though I haven't tested. > > It would be easier to review if you modified one or two packages > and services in guix itself to use this wrap-in-search-paths procedure > though. (Preferably services with a system test in gnu/tests/*.scm.) > Otherwise, guix would have a procedure that is not called from anywhere > and isn't tested either, which is a bit of a hard sell. > > Not sure how this helps with > >> First, when running on a foreign distro, guix packages (especially python packages) >> can break the foreign distribution by putting Guix's python interpreter before the >> host's in the PATH. Scripts that rely on a #!/usr/bin/env python shebang then breaks. >> This for example breaks gdm on the latest Ubuntu when you install any package for >> which python is a propagated input. > > , but this seems useful for shepherd services (as you mentioned). > > Greetings, > Maxime.