From: Chris Marusich <cmmarusich@gmail.com>
To: Carl Dong <contact@carldong.me>
Cc: ludo@gnu.org, 48721@debbugs.gnu.org
Subject: [bug#48721] [PATCH v2] gnu: gcc-8: Make static libs reproducible
Date: Fri, 04 Jun 2021 00:23:16 -0700 [thread overview]
Message-ID: <878s3qt7ob.fsf@gmail.com> (raw)
In-Reply-To: <20210603200518.1125690-1-contact@carldong.me> (Carl Dong's message of "Thu, 3 Jun 2021 16:05:19 -0400")
[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]
Hi Carl,
Thank you so much for looking into this! The patch looks reasonable to
me. I am definitely curious to try a fixed version of GCC (8 or
otherwise) to see if it helps to solve 41669!
Carl Dong <contact@carldong.me> writes:
> Here's a v2 of the patch, let me know if this suffices!
>
>> Well done. Did you observe it in practice? (On ‘core-updates’ maybe?)
>
> Thanks! Yes, we observed it when switching back from gcc-9 to gcc-8 for
> compiling Bitcoin Core. We use -static-libstdc++, which means that any
> non-reproducibility in libstdc++.a propagates into our produced binaries as
> well.
>
> To be clear, I was only able to identify the problem and fix thanks to your
> patch here:
> https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/patches/dico-libtool-deterministic.patch?h=b6094b1f0a6760b9f5296364cf5edb8a2e64953c
>
>
>> I’m surprised that this is still an issue since this was fixed in
>> Libtool proper long ago, probably before GCC 8 was released.
>
> Right, unfortunately GCC maintains their own version of libtool, which hasn't
> been synced with upstream for a while. I documented the details here:
> https://reproducible-builds.org/docs/archives/#gnu-libtool
>
>> The patch is big, but it looks like using ‘substitute*’ wouldn’t be an
>> easy task, so maybe it’s better this way. WDYT?
>
> Right, I think it'd be hard to construct a robust substitute* for this that
> doesn't have false negatives/positives.
I agree; a patch seems best.
> ---
>
> This fixes the nonreproducibility in gcc documented here:
> https://reproducible-builds.org/docs/archives/#gnu-libtool
>
> * gnu/packages/patches/gcc-8-sort-libtool-find-output.patch: New patch.
> * gnu/local.mk (dist_patch_DATA): Register it.
> * gnu/packages/gcc.scm (gcc-8)[source]: Apply it.
Can this patch also be applied to earlier versions of GCC, such as
gcc-7, which is currently the default GCC used for basically everything
on Guix's master branch? Or is it too different?
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-06-04 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 20:23 [bug#48721] [PATCH] gnu: gcc-8: Make static libs reproducible Carl Dong
2021-05-29 17:09 ` Ludovic Courtès
2021-06-03 20:05 ` [bug#48721] [PATCH v2] " Carl Dong
2021-06-04 7:23 ` Chris Marusich [this message]
2021-06-04 15:42 ` Ludovic Courtès
2021-06-04 15:46 ` Ludovic Courtès
2021-06-08 16:03 ` Carl Dong
2021-06-11 14:07 ` Ludovic Courtès
2021-06-11 22:17 ` Carl Dong
2021-06-13 9:49 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s3qt7ob.fsf@gmail.com \
--to=cmmarusich@gmail.com \
--cc=48721@debbugs.gnu.org \
--cc=contact@carldong.me \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).