From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MOhJAgEiumA1SgAAgWs5BA (envelope-from ) for ; Fri, 04 Jun 2021 14:52:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8NVfOQAiumChZwAA1q6Kng (envelope-from ) for ; Fri, 04 Jun 2021 12:52:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 934021BCF3 for ; Fri, 4 Jun 2021 14:52:16 +0200 (CEST) Received: from localhost ([::1]:34332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp9J9-0007hm-KS for larch@yhetil.org; Fri, 04 Jun 2021 08:52:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp9Iw-0007fm-2E for guix-patches@gnu.org; Fri, 04 Jun 2021 08:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp9Iv-0003mw-Qu for guix-patches@gnu.org; Fri, 04 Jun 2021 08:52:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lp9Iv-0000sd-PV for guix-patches@gnu.org; Fri, 04 Jun 2021 08:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48319] [PATCH] Check if #:tests? is unconditionally #t; not acceptable when cross-compiling Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Jun 2021 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 48319@debbugs.gnu.org Received: via spool by 48319-submit@debbugs.gnu.org id=B48319.16228110643314 (code B ref 48319); Fri, 04 Jun 2021 12:52:01 +0000 Received: (at 48319) by debbugs.gnu.org; 4 Jun 2021 12:51:04 +0000 Received: from localhost ([127.0.0.1]:45772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp9Hz-0000rN-UY for submit@debbugs.gnu.org; Fri, 04 Jun 2021 08:51:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp9Hx-0000qt-CK for 48319@debbugs.gnu.org; Fri, 04 Jun 2021 08:51:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33972) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp9Hr-0002wc-B3; Fri, 04 Jun 2021 08:50:55 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=42840 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp9Hr-0006jQ-2P; Fri, 04 Jun 2021 08:50:55 -0400 From: Mathieu Othacehe References: Date: Fri, 04 Jun 2021 14:50:53 +0200 In-Reply-To: (Maxime Devos's message of "Sun, 09 May 2021 14:35:57 +0200") Message-ID: <878s3peqtu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622811136; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=6fyBw16GGLkZjBv2mhAVEAS4rZkp49d56SWaRvkhWls=; b=Tvrz6E/JWlBe8nN5j02C8VSFyzCWxH+utIPhumnbFq+TbI/6Q/pHsfEL3h7oX1EnpZq808 KLK5buf8bjO1nulhyE7rZp9QKdscof0lOi1rvn/M7Fg4hfrRmXAa3UL5FMz5BopPcNYiri OAP45xtAlM3XepYCe+5u4eiZWYmy9nSFqP5d9DU92Wcy4zbhceFiWqJI1kxRx35OKjwYSB AxNH6DHhu87ZAM8XjP+3qcyc7heLPAPMDbN3LItDB9uHnrj9GwbxeB//Q56Z83rLJa8MPE 7bCNg7PL68Ej25DnfFYSfG55/tMdy/7CBBDdp9It21vZrUTY53UiX3vmsszyOw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622811136; a=rsa-sha256; cv=none; b=SdDTzWDOInEct2ziJjbis5/wlvbA0o5kaDGhrL2SrfFeGzaZYjTFcHm98wI4T6W+mtPHFt giQWdMQE3+nsmywn4gB94PUoRDIlDw7PQBBlONYLy3GDoH9CXoCK9nO+xtiVQXfwbPsvBg v43Walns0wLv35Gc8AmL+dU+/ML6DGUctLhzmPt9Qp3Hxfn/1si/Wx1NUQp9y/WTE0KWRj jOuhK6g5FkiRIJbYG4G/yaWJKw/ursnBrYLJVvVeFDVLUdre10j3tagTWU39wM2GJ4pEPj 5PY05F2CyiHjmrlUzuN+x5jsmnM5UsikEa7RNjdSOZtP0KbZTRMI2wwGxmwkmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 934021BCF3 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: UCliqjTor4AX Hello Maxime, > + ;; TRANSLATORS: #:tests? and #t are Scheme constants > + ;; and must not be translated. > + (G_ "#:tests? does not need to be explicitly set to #t") > + #:field 'arguments)) This patch looks fine, and I remember fixing multiple packages failing to cross-compile because #:tests was hard-coded to #t. I'm not sure about the warning message though. What about: "#:tests? must not be explicitly set to #t" as "does not need" implies it could be sometimes correct, whereas it is always a mistake. WDYT? Thanks, Mathieu