unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 48319@debbugs.gnu.org
Subject: [bug#48319] [PATCH] Check if #:tests? is unconditionally #t; not acceptable when cross-compiling
Date: Fri, 04 Jun 2021 14:50:53 +0200	[thread overview]
Message-ID: <878s3peqtu.fsf@gnu.org> (raw)
In-Reply-To: <ede44afaa1f52d80c0b6967524197fd0776b5ec2.camel@telenet.be> (Maxime Devos's message of "Sun, 09 May 2021 14:35:57 +0200")


Hello Maxime,

> +                          ;; TRANSLATORS: #:tests? and #t are Scheme constants
> +                          ;; and must not be translated.
> +                          (G_ "#:tests? does not need to be explicitly set to #t")
> +                          #:field 'arguments))

This patch looks fine, and I remember fixing multiple packages failing
to cross-compile because #:tests was hard-coded to #t.

I'm not sure about the warning message though. What about:

"#:tests? must not be explicitly set to #t"

as "does not need" implies it could be sometimes correct, whereas it is
always a mistake.

WDYT?

Thanks,

Mathieu




  reply	other threads:[~2021-06-04 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 12:35 [bug#48319] [PATCH] Check if #:tests? is unconditionally #t; not acceptable when cross-compiling Maxime Devos
2021-06-04 12:50 ` Mathieu Othacehe [this message]
2021-06-05  9:56   ` Maxime Devos
2021-06-06 16:51     ` bug#48319: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s3peqtu.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=48319@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).