unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Arun Isaac <arunisaac@systemreboot.net>, 49086@debbugs.gnu.org
Subject: [bug#49086] [PATCH] gnu: linkchecker: Update to 10.0.1.
Date: Sat, 19 Jun 2021 11:06:34 +0200	[thread overview]
Message-ID: <878s362pgl.fsf@yoctocell.xyz> (raw)
In-Reply-To: <87v96antw6.fsf@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Sat, Jun 19 2021, Arun Isaac wrote:

>> This 'check phase doesn’t respect the ‘--with-tests’ transformation.
>> Something like the following would be better:
>>
>>   (replace 'check
>>     (lambda* (#:key inputs outputs tests? #:allow-other-keys)
>>       (when tests?
>>         (with-directory-excursion "tests"
>>           (add-installed-pythonpath inputs outputs)
>>           (invoke "py.test" "tests")))))
>
> Makes sense. I'll add the `when tests?', but what's the
> with-directory-excursion for?

Oops, ignore the ‘with-directory-excursion’, sorry about that.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-06-19  9:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 12:00 [bug#49086] [PATCH] gnu: linkchecker: Update to 10.0.1 Arun Isaac
2021-06-18 14:18 ` Xinglu Chen
2021-06-19  8:25   ` Arun Isaac
2021-06-19  9:06     ` Xinglu Chen [this message]
2021-06-19 19:07     ` bug#49086: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s362pgl.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=49086@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).