From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wLsrEpV/7WAsmwAAgWs5BA (envelope-from ) for ; Tue, 13 Jul 2021 13:57:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gAX0DZV/7WCxWQAA1q6Kng (envelope-from ) for ; Tue, 13 Jul 2021 11:57:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD41D2DD5F for ; Tue, 13 Jul 2021 13:57:08 +0200 (CEST) Received: from localhost ([::1]:60282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3H2B-0006Xg-S8 for larch@yhetil.org; Tue, 13 Jul 2021 07:57:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3H26-0006Vu-Ra for guix-patches@gnu.org; Tue, 13 Jul 2021 07:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3H26-00038U-JL for guix-patches@gnu.org; Tue, 13 Jul 2021 07:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3H26-0004la-Jq for guix-patches@gnu.org; Tue, 13 Jul 2021 07:57:02 -0400 Subject: bug#29932: [PATCH 0/2] Clean up operating-system-kernel-arguments. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 13 Jul 2021 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29932 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 29932-done@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Mail-Followup-To: 29932@debbugs.gnu.org, maxim.cournoyer@gmail.com, dannym@scratchpost.org Received: via spool by 29932-done@debbugs.gnu.org id=D29932.162617738418276 (code D ref 29932); Tue, 13 Jul 2021 11:57:02 +0000 Received: (at 29932-done) by debbugs.gnu.org; 13 Jul 2021 11:56:24 +0000 Received: from localhost ([127.0.0.1]:39598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3H1U-0004ki-96 for submit@debbugs.gnu.org; Tue, 13 Jul 2021 07:56:24 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]:45940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3H1R-0004kS-Cl for 29932-done@debbugs.gnu.org; Tue, 13 Jul 2021 07:56:22 -0400 Received: by mail-qk1-f181.google.com with SMTP id p202so4837579qka.12 for <29932-done@debbugs.gnu.org>; Tue, 13 Jul 2021 04:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=eqmLlOU5jP7bqC9Pd+KA8iR3gJYQ8humIDvKe3XfX5k=; b=rBEEqa1+qui4ATOTN7Abg8jSU+FuGp3BL4BQqi3YO0zisacwAADWcQEv0pNlMVfg1H r8p4PxuaN+LWM7s6vp0JC0cAxPbGH/I2uLZlkpO9uEaOetNkiewLRFcLKLZ/TXBNe261 bgTlUOrfoBLGcAGnxXrfFyund9dIerzJ4mLxX0AuEa6oz4nE9OPP+Y2KmiVsYNCyH8Zd /eULIjB1FVUF/vMMDv82aDlWsQBw7HqG+XYJOCaO0mF5Z3/98cOIixOgxeaafFFCZH+G tCtveaeyXIKO2OFLuBrugN6cyNY8f4RLu74eHROGM2PlANp/cZNeHxZSezNU7nwgC2Y6 Zxww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=eqmLlOU5jP7bqC9Pd+KA8iR3gJYQ8humIDvKe3XfX5k=; b=WkEYwa2Sp/gUmokLvzhh4cYdi/UDZMXADVvfh1687QhfBp2IP2rxcCoaD6QtaYBVFi pLBM4qjGg5muGYdqIW5NTvOwhcRLN1JM3w5gzWzjkziBMXjxV6NyNC8a+vcnoA1mGseY qxa/s7J/HLNKjqwXclysAFSkvcbGZJ0QM34qA94oi5CBCUE0qyFf0CdMT79x7r91H134 Y61635h1WBptaA/UHDjwYEYIhy1ODf6PnCwoiUIz4nhs7tJlh9+uHq0MiejRojkuTdfg vXavbQqsK/q0sJSi0+kYtbt3Uzs3PFJarnBLCPpGxIoTuB/SUWlhB2/SK18K2H9NwX+i 9I4A== X-Gm-Message-State: AOAM531i5Iaq5b5tjR+YiIUJUyHAec7dIBOW5lSpw6FeZfVuLFT5bNWe tnld2vDu4GDUAm2FK374Ggc= X-Google-Smtp-Source: ABdhPJwM9xZ7/Wj70LMVZWjyYYwda+WUJCoK8QRPyVHI5u7e9JkLPVGWZ4KMfLbcWR0u3E3MkvzEsw== X-Received: by 2002:a37:45cf:: with SMTP id s198mr3784147qka.267.1626177375776; Tue, 13 Jul 2021 04:56:15 -0700 (PDT) Received: from hurd (dsl-10-136-19.b2b2c.ca. [72.10.136.19]) by smtp.gmail.com with ESMTPSA id j28sm7443069qki.52.2021.07.13.04.56.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 04:56:15 -0700 (PDT) From: Maxim Cournoyer References: <20180112105953.7198-1-dannym@scratchpost.org> <20180112110147.7305-1-dannym@scratchpost.org> <87o9lzqih9.fsf@gnu.org> <20180112154356.3fbd9177@scratchpost.org> <87k0w0txn4.fsf@gmail.com> Date: Tue, 13 Jul 2021 07:56:14 -0400 In-Reply-To: <87k0w0txn4.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 08 Oct 2020 13:50:39 -0400") Message-ID: <878s2atokh.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626177429; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eqmLlOU5jP7bqC9Pd+KA8iR3gJYQ8humIDvKe3XfX5k=; b=e+eTdHzUMdc0cM12E1Pzi0TlroMlPvUZYzDJpdyPYIVShq8W8a6IGGh/rdKoBAd7qM7/4/ 62kU0fBbPKy2i/iO634c7WKHCm8Luc5adooyI8ztzu28CdxOTtCrRajCGYzujnrcliFNIM CCh/4XiKtOfH/S2eJIBOzAMpCS+J9poJXJM0/m9wjCqbYuFFMsVCfk5qb4wVhnZcr0AQ/u eIMgozEJgUSBk4vqY5rG+/dgyg3Np2pHGSMysXmx525Ednt+9QMtQ4NY2DteEMuurQb9rR fXPhoetzyMF2yeWl7neJGDEfSjq7v73g4ORl6juhuALul2xW81P4adfK6cQsqg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626177429; a=rsa-sha256; cv=none; b=XKEbwqwXHwg5bYFmXTDaTdv0OHauGCBLVxMnH1Oqkzc/SnhEWX6be+hqJrxz3KmHOxHSCO v5ccmCgWcCidkQyee91VY0FInYWr/TKgk8jyQNbnyumQ04H3Kks6tiJeixdguQ3PjAGAD+ BkkFpeHFrqhfnh2VFqCCo9/rouEbig5BbsvK4YRxFgJfV9iZpBX9xp4NAsQexqDP3Rek6q Xza8STNINXQsO4VBrhp3OccKKCi9B/4H36DOcULhMPRHSIxVTkAAuKDEq/YlsfdyLIPKXq tPuWGK+j4hF8jA33DV/GA6doykoK6mrW9eBi6Z7OpaKcZFmNA6FFZGjC5H+NOg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=rBEEqa1+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=rBEEqa1+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DD41D2DD5F X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: +ksbfHn888ZF Hello, Maxim Cournoyer writes: > Hello, > > Danny Milosavljevic writes: > >> Hi Ludo, >> >>> I=E2=80=99m a bit lost: in my tree I don=E2=80=99t have >>> =E2=80=98operating-system-boot-kernel-arguments=E2=80=99. Is it still = pending? >> >> It's added by PATCH v2 1/2 from the series. Didn't the second mail get = through? >> >>> Otherwise my only question is whether it=E2=80=99s a good idea to move = away from >>> the =E2=80=98user-=E2=80=99 convention. On one hand, it=E2=80=99s the = convention we also have >>> for services (=E2=80=98-user-services=E2=80=99 vs. =E2=80=98-services= =E2=80=99), so it would be a good >>> thing to remain consistent. OTOH, what you propose is maybe clearer. >>>=20 >>> Thoughts? >> >> Yeah, I've split it into two patches because I actually got used to >> operating-system-user-kernel-arguments by now (only a few days in). >> We could only apply PATCH v2 1/2 and not apply PATCH v2 2/2 if we >> wanted. >> >> In the end it comes down to whether we deem the existence >> operating-system-boot-kernel-arguments an implementation detail or not >> (whether the user would ever need to be aware of >> operating-system-boot-kernel-arguments). We have to export >> operating-system-boot-kernel-arguments because one thing in >> gnu/system/vm.scm needs it - otherwise it would be very much an >> implementation detail. >> >> Let's see what the others say. > > Two years later, here's what I have to say :-) > > I think it's nice, as a user, to be able to inspect the dynamically > computed kernel arguments that Guix would use, as that can be used for > debugging and gaining a better understanding (e.g., when passing an > argument option that overrides one computed by Guix). > > If I followed this discussion correctly, currently we have: > > 1. operating-system-kernel-arguments which is a combination of > dynamically computed arguments by Guix + the users arguments and > 2. operating-system-user-arguments which are the users arguments > themselves. > > It is proposed here to split this into: > > 1. operating-system-boot-kernel-arguments for the Guix-computed ones > 2. operating-system-user-kernel-arguments remains unchanged > > Thus if the user wants to know what boot arguments their system will > use, they'd have to append these two together. > > I think that two years have elapsed without touching this is perhaps an > indication that it doesn't address any real problem :-). While it's > good to attempt to clarify things, I'm afraid that changing this would > confuse more that it'd help. As Ludovic pointed out, it'd also clash > with the convention currently in use for services. > > What you do think? There haven't been any further comments. Closing. Maxim