unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: 49823@debbugs.gnu.org,
	Leo Prikler <leo.prikler@student.tugraz.at>,
	Maxime Devos <maximedevos@telenet.be>
Subject: [bug#49823] [PATCH] gnu: Add jsonnet.
Date: Tue, 10 Aug 2021 14:58:40 +0200	[thread overview]
Message-ID: <878s19sbgf.fsf@gnu.org> (raw)
In-Reply-To: <71fbbaa57a2c1dba8f0d956ea162c2e15d332e0c.camel@planete-kraus.eu> (Vivien Kraus's message of "Mon, 02 Aug 2021 17:01:07 +0200")

Hi Vivien,

Vivien Kraus <vivien@planete-kraus.eu> skribis:

> Here is jsonnet. I don’t fully understand what it does, but thanks to
> leoprikler, I know it is a dependency to package GraalJS, an
> interpreter for JavaScript on the Java Virtual Machine.
>
> For the sake of having "no dependencies", it bundles a custom
> implementation of MD5. According to a comment in the associated
> license, it is taken from the implementation of bzflag, but it does not
> seem to use the same as of today.
>
> I decided to use nettle, and add a few lines of C++ to shape it into
> the required interface.

I think using Nettle is a wise decision; however, it’s a decision for
upstream to make IMO.  I’m not comfortable with shipping custom
md5.{cpp,h} and CMakeLists.txt; to me, we’d be taking a bit too much of
upstream’s burden and delivering something that’s quite different.

Apart from that, the last patch you sent LGTM.

Thoughts?

Thanks,
Ludo’.




  parent reply	other threads:[~2021-08-10 12:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 15:01 [bug#49823] [PATCH] gnu: Add jsonnet Vivien Kraus via Guix-patches via
2021-08-02 16:15 ` [bug#49823] Using texinfo for the description Vivien Kraus via Guix-patches via
2021-08-02 16:35   ` Maxime Devos
2021-08-02 17:09     ` Vivien Kraus via Guix-patches via
2021-08-02 17:52       ` Leo Prikler
2021-08-02 23:21         ` Vivien Kraus via Guix-patches via
2021-08-10 12:58 ` Ludovic Courtès [this message]
2021-08-10 14:28   ` [bug#49823] [PATCH] gnu: Add jsonnet Vivien Kraus via Guix-patches via
2021-08-11  9:56     ` Ludovic Courtès
2021-08-11 10:12       ` Vivien Kraus via Guix-patches via
2021-08-12  7:53         ` bug#49823: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s19sbgf.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=49823@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=maximedevos@telenet.be \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).