From: Xinglu Chen <public@yoctocell.xyz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 50317@debbugs.gnu.org
Subject: [bug#50317] [PATCH 0/2] Update ‘ocaml-ppxlib’
Date: Sat, 04 Sep 2021 12:56:07 +0200 [thread overview]
Message-ID: <878s0chans.fsf@yoctocell.xyz> (raw)
In-Reply-To: <87lf4dz980.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]
On Fri, Sep 03 2021, Ludovic Courtès wrote:
> Hi,
>
> Xinglu Chen <public@yoctocell.xyz> skribis:
>
>> ‘ocaml-ppx-optcomp’ fails to build with the new ‘ocaml-ppxlib’, updating
>> it makes it build again.
>
> In that case, I’d suggest updating both in the same commit, so that each
> commit contains a working package set.
Or maybe I could reorder the commits so that the ‘ocaml-ppxlib’ update
comes last?
>> gnu: ocaml-ppxlib: Update to 0.23.0.
>> gnu: ocaml-ppx-optcomp: Update to 0.14.3.
>
> Unfortunately, at least one dependent fails to build:
>
> --8<---------------cut here---------------start------------->8---
> starting phase `build'
> File "src/ppx_variants_conv.ml", line 69, characters 22-41:
> 69 | if Caml.Hashtbl.mem Lexer.keyword_table s
> ^^^^^^^^^^^^^^^^^^^
> Error: Unbound value Lexer.keyword_table
> command "dune" "build" "@install" "--profile" "release" failed with status 1
> builder for `/gnu/store/g73id3dchmqc0dirv9ahzmgbwsyba78b-ocaml-ppx-variants-conv-0.14.1.drv' failed with exit code 1
> --8<---------------cut here---------------end--------------->8---
>
> Could you check this one and other packages returned by ‘guix refresh -l
> ocaml-ppxlib’?
>
Good catch! There is a patch that should fix this issue[1]; should I
apply the patch to fix the build?
I didn’t build the ‘ocaml-llwm’ packages since I would have to first
build ‘llvm’ from source...[*]. The ‘ocaml-markup0.8.0’ fails too, but
it was already failing before applying this patch, so I will send a
separate series to try to fix it. I also had to update ‘ocamlformat’ to
make it build.
Thanks for the taking a look!
[*]: I have noticed that substitute availability has been pretty poor
lately. :-(
[1]: <https://github.com/janestreet/ppx_variants_conv/pull/9>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-04 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 12:58 [bug#50317] [PATCH 0/2] Update ‘ocaml-ppxlib’ Xinglu Chen
2021-09-01 13:13 ` [bug#50317] [PATCH 1/2] gnu: ocaml-ppxlib: Update to 0.23.0 Xinglu Chen
2021-09-01 13:13 ` [bug#50317] [PATCH 2/2] gnu: ocaml-ppx-optcomp: Update to 0.14.3 Xinglu Chen
2021-09-03 20:37 ` [bug#50317] [PATCH 0/2] Update ‘ocaml-ppxlib’ Ludovic Courtès
2021-09-04 10:56 ` Xinglu Chen [this message]
2021-09-06 8:07 ` Ludovic Courtès
2021-09-06 13:49 ` Xinglu Chen
2021-09-06 14:06 ` [bug#50317] [PATCH v2 0/4] " Xinglu Chen
2021-09-06 14:06 ` [bug#50317] [PATCH v2 1/4] gnu: ocaml-ppx-optcomp: Update to 0.14.3 Xinglu Chen
2021-09-06 14:06 ` [bug#50317] [PATCH v2 2/4] gnu: ocamlformat: Update to 0.19.0 Xinglu Chen
2021-09-06 14:06 ` [bug#50317] [PATCH v2 3/4] gnu: ocaml-ppx-variants-conv: Patch for building with ocaml-ppxlib Xinglu Chen
2021-09-06 14:06 ` [bug#50317] [PATCH v2 4/4] gnu: ocaml-ppxlib: Update to 0.23.0 Xinglu Chen
2021-09-06 21:36 ` bug#50317: [PATCH 0/2] Update ‘ocaml-ppxlib’ Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s0chans.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50317@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).