unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 50664@debbugs.gnu.org
Subject: [bug#50664] [PATCH core-updates-frozen] gnu: curl: Respect #:tests?.
Date: Sun, 19 Sep 2021 15:50:18 +0000	[thread overview]
Message-ID: <878rzsd0p1.fsf@gnu.org> (raw)
In-Reply-To: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Sat, 18 Sep 2021 10:14:34 -0700")


Hello Sarah,

> +          (lambda* (#:key (tests? (not target)) #:allow-other-keys)

I'm not sure we need the default value here, as it's already part of the
build system.

Otherwise looks nice. We can apply when merging other world rebuilding
changes, or directly on core-updates for the next round.

Thanks,

Mathieu




  reply	other threads:[~2021-09-19 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 17:14 [bug#50664] [PATCH core-updates-frozen] gnu: curl: Respect #:tests? Sarah Morgensen
2021-09-19 15:50 ` Mathieu Othacehe [this message]
2021-09-19 18:46 ` [bug#50664] [PATCH core-updates-frozen v2] " Sarah Morgensen
2021-11-12  5:52   ` bug#50664: [PATCH core-updates-frozen] " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rzsd0p1.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=50664@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).