From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aHFyBDQ6bWEiqQAAgWs5BA (envelope-from ) for ; Mon, 18 Oct 2021 11:11:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +KEBADQ6bWG2aQAAbx9fmQ (envelope-from ) for ; Mon, 18 Oct 2021 09:11:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E3DE2C28E for ; Mon, 18 Oct 2021 11:11:15 +0200 (CEST) Received: from localhost ([::1]:60118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcOfq-0004dy-Ir for larch@yhetil.org; Mon, 18 Oct 2021 05:11:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOfe-0004cq-Rh for guix-patches@gnu.org; Mon, 18 Oct 2021 05:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34460) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcOfe-0002rO-J3 for guix-patches@gnu.org; Mon, 18 Oct 2021 05:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcOfe-0004Qu-ED for guix-patches@gnu.org; Mon, 18 Oct 2021 05:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50814] [PATCH] guix: git-authenticate: Also authenticate the channel intro commit. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Oct 2021 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 50814@debbugs.gnu.org Received: via spool by 50814-submit@debbugs.gnu.org id=B50814.163454825317024 (code B ref 50814); Mon, 18 Oct 2021 09:11:02 +0000 Received: (at 50814) by debbugs.gnu.org; 18 Oct 2021 09:10:53 +0000 Received: from localhost ([127.0.0.1]:46006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcOfU-0004QQ-UB for submit@debbugs.gnu.org; Mon, 18 Oct 2021 05:10:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcOfS-0004QB-AX for 50814@debbugs.gnu.org; Mon, 18 Oct 2021 05:10:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60634) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcOfM-0002cb-Ox; Mon, 18 Oct 2021 05:10:44 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=50988 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOfJ-0008RK-NG; Mon, 18 Oct 2021 05:10:44 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210926101928.3877-1-attila@lendvai.name> <878rz2xq23.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Oct 2021 11:10:39 +0200 In-Reply-To: (Attila Lendvai's message of "Sun, 17 Oct 2021 10:09:24 +0000") Message-ID: <878ryqbsvk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634548275; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=TwBagHzslU4C62qdh3QZY0lJIc+g607mLEoJ7xZVP/Y=; b=tNFAnBkMU1htgP7BDKHJc76404lovHEUBLItbtfBVEctft9KYs6tetoOhNZXAI/5lBzicv +ifEjAG2VT5ngugKtp9pUO+D/XUg2LHbrTyteS+F6Y3BGgGW2JFnicPMY6OmAMwf8ARg+h mm/eFE4+g3t6yYqnT0BAT/8GQGwkbIfFlGif9vX0lJnENpmVhlJWj6xDm55F1z76uKyvsN 59kAU7TDxen5Eners7Ai4nXxy6D7//Rr+DqsZrJ3gu9OkWqXdYob+BKCriNpLo8sprXhYU snWxNaBsH5KXdYreojVPX/IQ9SOtVX1p+acyq5ottdjY7bn0tjYMmIfjOMIc1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634548275; a=rsa-sha256; cv=none; b=Wg6E1V+4RJQJ9TKvWAc1iFXN+SLQF237+IjM9LbBhQMTMwV+tPQkZC6kFnmpC5RMy2sE3E lOfFOTvZuIXAzr2XJLKF3muqao0l7kcHpn5re4nupoi+kk+c/HL2JJ22fvs7DZ1YEGypat O6xQ7osJEvr5TtICgtCuve9bzoA9uHT+WwIf8DUnRIHo9gk6n7PbZd0tGphEg+VzRxuPDO ZWTVvxM1IiU/keyQ6hzVh4RlGyoBczJa6afFu0slSe34FxsEtljZZJ4RkdnMzn5cCp3zo+ 0p07x2mLF0kt9SBE/ycxkpIAKT+3Wry4VTtPnAE+ZN4tuTVF8g4QRkX01Oyycg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7E3DE2C28E X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: QZvyBNu3Pc52 Hi Attila, Attila Lendvai skribis: >> i'll investigate again later by running the test without the fix, and wr= ite >> up my results here, or better yet, in a better commit message. > > i ran the test without my fix, and indeed it fails at two points: Sorry, which test is failing? Is that part of the patches you sent? I need more context. :-) [...] >> Alright. Please next time open one issue per topic: that=E2=80=99s a go= od >> way to maximize the chances that review happens in a timely fashion. >> :-) > > > can i mark dependencies between issues/patchsets? > > because all that i could do here is split this into two sets of > commits (because of the dependencies between the commits): > > 1) the 3 test commits, and > 2) the 2 guix commits. > > i thought that separating the test that is exhibiting the bug, from > the fix that fixes it, would only hinder the process. Yes, in general it=E2=80=99s best to have the test and the fix in the same commit. However, at this point, I=E2=80=99m not sure which =E2=80=9Cbug=E2=80=9D we= =E2=80=99re talking about. What you described in your initial message is not a bug in my view: https://issues.guix.gnu.org/50814#28 >> I understand the behavior was surprising to you, but I=E2=80=99d like to= see >> if we can pinpoint why. Can you think of anything that could be >> added to the documentation? > > > if we assume that everyone reads and internalizes every page of the > documentation of every software that they use, then i guess nothing > needs to be added. > > but if our goal is to maximize the effectiveness of the users, then no > amount of static, free-flowing text can compete with a warning that is > signalled in close context to the issue. Sure, I agree. However, you=E2=80=99re clearly a power user at this point :-), and we=E2= =80=99re talking about one of the most sensitive pieces of code in Guix. I think it=E2=80=99s important to make sure we=E2=80=99re on the same level of unde= rstanding of the design and current implementation; I also think it=E2=80=99s not unreasonable to expect channel writers to pay attention to documentation on these matters. I=E2=80=99m not saying that we should not change anything, but rather that = it=E2=80=99s not like a simple usability/UX issue. I hope this makes sense! Ludo=E2=80=99.