From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2D8VGfuJf2H6KAEAgWs5BA (envelope-from ) for ; Mon, 01 Nov 2021 07:32:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aKTFFPuJf2HicgAAB5/wlQ (envelope-from ) for ; Mon, 01 Nov 2021 06:32:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5AB4185C2 for ; Mon, 1 Nov 2021 07:32:26 +0100 (CET) Received: from localhost ([::1]:59596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhQrp-0007kS-GA for larch@yhetil.org; Mon, 01 Nov 2021 02:32:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhQrS-0007kH-LI for guix-patches@gnu.org; Mon, 01 Nov 2021 02:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhQrS-0007dL-BC for guix-patches@gnu.org; Mon, 01 Nov 2021 02:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhQrS-0003md-6M for guix-patches@gnu.org; Mon, 01 Nov 2021 02:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50873] [PATCH 0/5] Fixes to =?UTF-8?Q?=E2=80=98guix?= home =?UTF-8?Q?import=E2=80=99?= Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 Nov 2021 06:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Oleg Pykhalov , 50873@debbugs.gnu.org Received: via spool by 50873-submit@debbugs.gnu.org id=B50873.163574831014526 (code B ref 50873); Mon, 01 Nov 2021 06:32:02 +0000 Received: (at 50873) by debbugs.gnu.org; 1 Nov 2021 06:31:50 +0000 Received: from localhost ([127.0.0.1]:33595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhQrG-0003mD-85 for submit@debbugs.gnu.org; Mon, 01 Nov 2021 02:31:50 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:44655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhQrD-0003lz-UN for 50873@debbugs.gnu.org; Mon, 01 Nov 2021 02:31:48 -0400 Received: by mail-lf1-f50.google.com with SMTP id y26so34319759lfa.11 for <50873@debbugs.gnu.org>; Sun, 31 Oct 2021 23:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=1+qWmbcqvm/pUF5hdULnOHMj6MS70LNMfAF/nEWF0NI=; b=dFQwFAlu4cj8qOjKPJHNlbr4OupqPpCTOPwGSYFYb56NUNOn3S/bh8zctbtTf6SRO2 QsNIjFRCfTfo78Rr/FKd9zHkf3C1h9g+GE8zJv/ku4Dn5y6Au+RcnrDZ+CIqdXCsusPn M8HFw22I+r4ChOV6+N3sVJ14XkCobXtZ76p+E3paA9Gu049PNDEKtzHiM8qrF9WX+WIn XAJ/jbzAiLYMKU8UTTrof8+LosUiTGRuKK8ZMDUYmxHfEAb4od6wCpicdzceHzCtt6iM L0hUx+A67EHC/Vj7HobZFqryastYqR1lhWuM790QmD0IKrwthUP6GVYwPU6aqfEZ99eX Zw2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=1+qWmbcqvm/pUF5hdULnOHMj6MS70LNMfAF/nEWF0NI=; b=bad5LF75+1VpYCS7LX+PvTG4EKo11oYno+g4KE2DACPHBl0nSAM//EM9TGhtZ1O79X 2f4SFMVpU4D5kS9y3VMas6U0zaosnY/aXm6w2AJ7lfUHAK7pZkGINIYtSZkSllTWTSDC VZzkLid+GydCi7fPJWM7bTfzWKtq7slJkPcatniSTqz5hG3uckohyIPhoxbNGNPpwTzW RGW8ESh92E1TpcJLVsundksqYxTRfC6DK2UM+W7MCerbjftd6UHjDtPzsIfJrXsipbpl qiernjTAJOQ/joVHGoq+Sq07X/3YZnoegi5w103BPjmV7dRcxdgLU/azFWLNxxw9GJUC bE7w== X-Gm-Message-State: AOAM533qCgIzEznHcPQAT5uqG56EEaDiMqCAv9mMitecueIyntvTZhIt h1/oZ8hEruWzCvkl+lAZRfIV+g== X-Google-Smtp-Source: ABdhPJwIKaYx547U2haZluMMzNu6lIGDdMwAAY1qjmj1Z0DMbNC7U6Gf0axRj1Mbjkuu6ttda49bhQ== X-Received: by 2002:a05:6512:20d:: with SMTP id a13mr6975513lfo.76.1635748301848; Sun, 31 Oct 2021 23:31:41 -0700 (PDT) Received: from localhost (109-252-140-132.dynamic.spd-mgts.ru. [109.252.140.132]) by smtp.gmail.com with ESMTPSA id b13sm1319009lfb.145.2021.10.31.23.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Oct 2021 23:31:41 -0700 (PDT) From: Andrew Tropin In-Reply-To: <878ry96qn6.fsf@disroot.org> References: <8735oirub9.fsf_-_@gnu.org> <878ry96qn6.fsf@disroot.org> Date: Mon, 01 Nov 2021 09:31:37 +0300 Message-ID: <878ry8tmie.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635748347; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1+qWmbcqvm/pUF5hdULnOHMj6MS70LNMfAF/nEWF0NI=; b=hM/yVuPEXegjCosDKSNzfeLoOawj9q8N7dx0x1fzdF0UxPiyYH5MLnJ0xLl4U2sKuM8N6z txPP5b+enquJ41SsFQDa16tcX+A0y4KF37/2qIo+Jvf76t8W3Hb/JB3SGMA9QjufvtleAF uYAdMLHx+e+19ms08Bv3aCAfyYs0Qs0AYdiCfhpuR46nhXMc+lfewnBbebnw4qcO/R4Gbx bDG5X7TI8YiqG4FDuLB0g0+m+G1lBxTUBRZT2cqlhhTaKdA3xUL6MJe+U3iOBiTU1Ao30r hr37Nmwzd1Z/aZ26GunTUBCvnMDVyI2BJxgBGmY/WTZ460lJbwWyJbVwJ66ghg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635748347; a=rsa-sha256; cv=none; b=oC+GmqhcMgNw0iBy8dcl7SXilTbxhSTs+CganCD30WCVj4y15EFWqhTSsYLKjrhMcv/0bQ VxoyeePro7wDzXYpWl4o3pAK+jIlqILr+tWOkO1eiVHoByEjzH4aUNWRIIkXklVD/2AN+u wqSuK1kJotEEq/knXBrLbRIRdPdHai7LvmasEt/3FY5Kos/BfTrVj18GIPwWTrKTOqAQ4e X49aK2LUj56cJza9myedJ403Nlzpspqp+VXEV0ve8Jo4gSBp3In3rCijRggERvse9A7WlM UoamDJofbG50TAdpQcD5dye4B1fwvGCyfER149zwXdapBrZC1+8oWe1vW5kiHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=dFQwFAlu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=dFQwFAlu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A5AB4185C2 X-Spam-Score: -2.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: caSfZUOEf4w7 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-10-31 18:38, Xinglu Chen wrote: > Hi, > > On Sun, Oct 31 2021, Ludovic Court=C3=A8s wrote: > >> Hi! >> >> Xinglu Chen skribis: >> >>> guix home: import: Make the user to specify a destination directory. >>> guix home: import: Allow multiple modules to be imported for each >>> service. >>> guix home: import: Fix module name for Bash service. >>> guix home: import: Don=E2=80=99t use 'slurp-file-gexp'. >>> guix home: import: Delete duplicate modules when importing. >>> doc: Document the =E2=80=98guix home import=E2=80=99 subcommand. >>> Add tests for =E2=80=98guix home import=E2=80=99. >>> guix home: import: Call =E2=80=98local-file=E2=80=99 with =E2=80=98na= me=E2=80=99 argument. >> >> That=E2=80=99s a nice improvement. In the interest of moving forward, I= applied >> the whole series and followed up with a few changes: >> >> c4ac8cf4f6 doc: Mention 'guix home reconfigure' upfront. >> 971a69d8e3 doc: Avoid misuse of @ref. >> 7711a6c3f4 doc: Mention "guix home import" upfront. >> 6f4ca78761 home: import: Avoid duplication of 'manifest->code'. >> 96728c54df home: import: Factorize triplicated 'version-spec' procedur= e. >> f3933ae40d home: import: Clarify "destination directory". >> 341fba217f home: import: Compare procedures with 'eq?'. >> >> Part of it is about removing duplicated code, in particular >> =E2=80=98manifest->code=E2=80=99. It=E2=80=99s important to factorize n= on-trivial code like >> this. >> >> The last commits improve documentation so users learn about =E2=80=98gui= x home >> import=E2=80=99 when they get started. > > Thanks for taking care of this! > >> It=E2=80=99s really nice to have this tool! I find it perhaps a bit con= fusing >> to have to specify a target directory to =E2=80=98guix home import=E2=80= =99; simply >> trying to document it shows that it=E2=80=99s non-obvious. >> >> I wonder if the argument should be optional (in which case the files >> wouldn=E2=80=99t be copied). But then people are likely to run into the >> problems this addresses. > > Yeah, that could be a bit confusing for people. > >> Or perhaps it would be more consistent to have: >> >> guix home import ~/foo >> >> create ~/foo/config.scm, instead of printing it to stdout? It's a good idea. home.scm or home-config.scm can be another option to make it clearer that it's not a system config.=20 >> >> The documentation would be clearer: =E2=80=9Cpopulate ~/foo with all the >> configuration files of your home environment.=E2=80=9D Thoughts? > > I originally made it to print to stdout because that=E2=80=99s what the = =E2=80=98guix > import=E2=80=99 commands do, but it could make sense to just populate a f= ile > directly. I don=E2=80=99t really have a strong opinion on this, so if no= body > has any objections, I could send a patch for this. :-) =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmF/ickACgkQIgjSCVjB 3rDgGg/+JyO6FTPyW8Jsc58J+8062CqNNnua/JzuAWHdC2aAsyicWAVSi6Xg4kH9 263KtqG8dehXLMPu7ebo4kc9CEa/CUB+uuGnl6qyMguefYjyBBKIM7aKb4wVe2LN aJgOJuHfEf/CMiSszDUF1r/EIAIZZqmT8OfmsP86VC/YCzu8fnYe1Uox8qBqs1LL LMbsfBGRQqUaPShOvGFOYBHud1rKngVXgtJamIVpXCfFlfOMH4D4qbDvxaBNLUJd qA4Uj/C+yCFOXX6uqnI45rs5Fk7LwQC9im0N9v13cDqvR6ccSxZluN+MOu5QZ6Md 9HOysQJakVzE7s3dK2JwcPBOMqfIKe/4GWWwBGGb5w/X1+zbN531FtiYZDiuGg+G K9h+bLRVpUCYkAxCYY+cHVCQarFia3FiDnn0X+GaYHe1YPbBY/lg1rWF+fxv1rjh Q516a8RC99JcmB5LWoXbNlPk45y1BqP2H4i85SxOnwwjsYLHpDum1Ubs7S5qmPbH k9yiFweC6Pq9P3nQkn/vpd9kYbSXa3mYKbqfFpd51uq2c0rXlWV4ANXplrqkBBht njTmn4MIBZ7TuALcjv+K7poaq6KdXDyxt3QBtds79aj2MbkAr4Z8Ohi8Roq8SczK fjpSV7meD0HqUr7uUZH9B3LWvbaXk0F2yCh8Ifr/UDaHWHymZUM= =4nQ9 -----END PGP SIGNATURE----- --=-=-=--