From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MB89FM8alWEpDQEAgWs5BA (envelope-from ) for ; Wed, 17 Nov 2021 16:07:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wI/rD88alWHOMAAA1q6Kng (envelope-from ) for ; Wed, 17 Nov 2021 15:07:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F12C6F5F1 for ; Wed, 17 Nov 2021 16:07:57 +0100 (CET) Received: from localhost ([::1]:38196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnMXU-0002se-NI for larch@yhetil.org; Wed, 17 Nov 2021 10:07:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnMTi-0006fO-Se for guix-patches@gnu.org; Wed, 17 Nov 2021 10:04:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnMTi-0002yc-K2 for guix-patches@gnu.org; Wed, 17 Nov 2021 10:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnMTi-0006VY-Cw for guix-patches@gnu.org; Wed, 17 Nov 2021 10:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Nov 2021 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.163716139424926 (code B ref 50072); Wed, 17 Nov 2021 15:04:02 +0000 Received: (at 50072) by debbugs.gnu.org; 17 Nov 2021 15:03:14 +0000 Received: from localhost ([127.0.0.1]:33444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnMSv-0006Tv-Rd for submit@debbugs.gnu.org; Wed, 17 Nov 2021 10:03:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:32962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnMSu-0006TS-4s for 50072@debbugs.gnu.org; Wed, 17 Nov 2021 10:03:12 -0500 Received: from [2001:470:142:3::e] (port=34950 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnMSo-0002qY-LO; Wed, 17 Nov 2021 10:03:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=w1moGtBiozGM2BE5wZOkQLY+JWD7x3t1Zn9mWWqxfqk=; b=lLa+QD671nxBgBqQtFZq isC4itqdIGHddWvzpRiOE5+gL4QatZPhD2LGHZB8NlouTy6puxWT8/y/vP36qYyAbeBjpin4GsY7H QP7KtcaL+pwUK5hxFTP5j95KqQ4dgGAJ9T+YSIn7vjSZbc0GyIn0MW9fEB15F3J3BQp85fXmWKeo2 881KEnzVWzqqUedlI7KARUN23/6PWoIWd4EZmRLaPF4iNVDEdgUTBcE4FEu4ITkOsIHZZ6mmVaLCq Rs4KGxkTVARzym/BIozOVocX/cwZS/mVMHBUxdCmip9A1FearsfYmzI31h0KdbNwcpdHqVt3uP5U7 nTCxHjsYxjd+ag==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53972 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnMSo-0008Uj-Dw; Wed, 17 Nov 2021 10:03:06 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> <87fsui80dd.fsf_-_@gnu.org> <86k0jti1r4.fsf@mgsn.dev> <87a6jv6pgm.fsf_-_@gnu.org> Date: Wed, 17 Nov 2021 16:03:02 +0100 In-Reply-To: <87a6jv6pgm.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 29 Sep 2021 23:28:57 +0200") Message-ID: <878rxmx1sp.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637161678; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=w1moGtBiozGM2BE5wZOkQLY+JWD7x3t1Zn9mWWqxfqk=; b=MscE2YbPJiUb2zNR0KMq3SJ/ubqYre5gDUf4+oAU1YGK50NklV164G9oj9gG69CEVHraJr BppgDvjWQviI/VpCrn6u8RNvXZykBo5/dGgFVC/G/ESN9yINBjYLnY4ACclZ/vOPsaMuwA audG+FmZL0z8KrW3DhyK58W7Q9WeBAVUUBjssSP9tlikxHVximKZ4mhd12fBCEX2y3wC0I yDWuHkVFyn09Xo9mV+B92Ind4uDX8xgzFolC/LaeRxfBhBB0rdPN3zxhmPo20Ftlc4xPHr idydShvMJsoh+olyqxmIBnCcv6wviMN2FRYCgpxVbWGQk6FnBaL5wXJAem7EbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637161678; a=rsa-sha256; cv=none; b=g10lVklgjAVZQ23RrKePgiGDIBtm4y6AwodOCQjsxs3O17x+1ejCJhueQHR+OfAQnIowJ3 KLbrpf9cxmpnTnYcNzolTwpSQLVf1+BFGtBz8tqSYbzPZjL9fiHLv2CH+wvAxcc9asI1Im ujkGg2nmTalGwwokGP8eE7l1/KCXjW6BVmpDUKGEfdkprbfHzLZuY5d/y61qEM6OTiYxrE e0sVn7q7fR3PAFQ3cUdsmd47Nln35m7A8XDuD4lCm+Bl6iR30W7fqI1l5fng+dlHhrFTR5 NqUr1twCBkXAdV091RM5l006phmz6qfWD3LIVtABDVsGwxiAw6MqPqxXVqgOaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lLa+QD67; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lLa+QD67; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F12C6F5F1 X-Spam-Score: -3.56 X-Migadu-Scanner: scn1.migadu.com X-TUID: J2caHRGA27oQ Hi Sarah, Friendly reminder about this patch set: https://issues.guix.gnu.org/50072 To me, it=E2=80=99s pretty much ready now that we can use =E2=80=98package-definition-location=E2=80=99 so that =E2=80=98guix refresh= -u=E2=80=99 edits the right bits. If you=E2=80=99re not able to work on it these days, I can tweak it for =E2=80=98package-definition-location=E2=80=99 use and push it on your behal= f. Let me know! Thanks, Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Hi Sarah, > > I just noticed I hadn=E2=80=99t answered this message=E2=80=A6 > > Sarah Morgensen skribis: > >> Ludovic Court=C3=A8s writes: > > [...] > >>> Sarah Morgensen skribis: >>> >>>> * guix/git-download.scm (checkout-to-store): New procedure. >>>> * guix/upstream.scm (guess-version-transform) >>>> (package-update/git-fetch): New procedures. >>>> (%method-updates): Add GIT-FETCH mapping. >>> >>> This LGTM. >> >> Thanks. WDYT about pre-emptively adding support for non-url URIs as >> well? That is, >> >> 1. change "urls" in to "uri" >> >> 2. in 'git-fetch' >> >> a) if the upstream-source-uri is a git-reference, just use it as-is >> rather than guessing the tag >> >> b) if it's not, return an 'upstream-source' with a git-reference URI=20 >> >> 3. update 'upstream-source-compiler' to work for git-reference URIs. >> >> If there are no objections, I think I'll make those changes and send >> that as a proper patch. > > That sounds like a good idea. We=E2=80=99ll need to check users of > =E2=80=98upstream-source-urls=E2=80=99 & co. and see whether/how they can= deal with > generalized =E2=80=9CURIs=E2=80=9D. > > That said, perhaps it can come after this patch series, which I think > was mostly waiting on =E2=80=98package-definition-location=E2=80=99 initi= ally? > > Thanks, > Ludo=E2=80=99.