From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iNiZI/OxmmF7JwEAgWs5BA (envelope-from ) for ; Sun, 21 Nov 2021 21:54:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UMoqH/OxmmGsDQAAbx9fmQ (envelope-from ) for ; Sun, 21 Nov 2021 20:54:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A3A92EF22 for ; Sun, 21 Nov 2021 21:54:11 +0100 (CET) Received: from localhost ([::1]:37834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1motqk-00089h-5Z for larch@yhetil.org; Sun, 21 Nov 2021 15:54:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motqc-000892-St for guix-patches@gnu.org; Sun, 21 Nov 2021 15:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1motqc-0002JR-KS for guix-patches@gnu.org; Sun, 21 Nov 2021 15:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1motqc-0006su-Fh for guix-patches@gnu.org; Sun, 21 Nov 2021 15:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51920] [PATCH] gnu: Add inkbox. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Nov 2021 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51920 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51920@debbugs.gnu.org Cc: phodina@protonmail.com X-Debbugs-Original-To: phodina via Guix-patches via X-Debbugs-Original-Cc: phodina , 51920@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163752798626376 (code B ref -1); Sun, 21 Nov 2021 20:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2021 20:53:06 +0000 Received: from localhost ([127.0.0.1]:46176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motpi-0006rL-Cy for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:53:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:39490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1motpg-0006r8-FK for submit@debbugs.gnu.org; Sun, 21 Nov 2021 15:53:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motpf-000870-Pp for guix-patches@gnu.org; Sun, 21 Nov 2021 15:53:03 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:38333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1motpe-0002Ew-0Y for guix-patches@gnu.org; Sun, 21 Nov 2021 15:53:03 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 67762200009; Sun, 21 Nov 2021 20:52:59 +0000 (UTC) From: Nicolas Goaziou References: Date: Sun, 21 Nov 2021 21:52:57 +0100 In-Reply-To: (phodina via Guix-patches via's message of "Wed, 17 Nov 2021 11:50:45 +0000") Message-ID: <878rxhut7a.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637528051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=ip3nDy9NZ5LpSC91KnmYofPnGXTB97d/D0PzkdqiG8w=; b=NO1YuHdg8DkIkYCcxMjM7pmwAvUPNz0+KH8/6eT4AXStf0cu3Hdd8c2rZ5aSwIOkGk4tkn yjHHJ6PNY+nkbaXDs3jLgWkEnclSLuzTmibLyw5Th1PDuwLvz6TXDoO1e9/ymFsmjl0zTa LioDRSq8TPBhS9xVuT32k1e47FJDXAjtO5qfFK6hsNCxzDFB1ekEG4Aq9PqP/oVg23I7eW +8yRhnY6N30WaLfr76DSf+l1jy0KjZXuNZesDmEHI9L+cZluGWY7vczZEsfJVaBAGMAfgv 83rzdJBjBsSunS9NFIrdoHrKTWFKz+zbwuXIbYHwt80+CFs7AkSMZqvrSd8xLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637528051; a=rsa-sha256; cv=none; b=FTL0GgTmG7vmYy/2YGWMdNM+yX6U7T9p1ZaiYp0hTApRf3jhw1WL6ob2fhtkgZDYRfMdrM Pmawv2uzydYpO0z8xbmaJMkbT5cR9CoFbVyCzQQrMQnp+HZYzoKqlUB3zN4Kes8ikR6FFL ll5QWOg4BZnu0r1HU0xcPJ/u9TjtjrnQLeInwXrGJOBlHJIpuAUW4IVFfyofofKLHU4Uq9 0EO/9yu2c/M8AqaT/vQ+UbMki/ftE6GBRfHNvsK/pnzI9qwwW9Zmq4l81MT5RgnAbrRCjT 8rzkL4Ca2AwAnxord9A5z/Gt6BhtPh+nCzk96WSwTiUtt3IAPx1QpHp+zpLV2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.18 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2A3A92EF22 X-Spam-Score: -3.18 X-Migadu-Scanner: scn1.migadu.com X-TUID: 1dCSABZ3MHae Hello, phodina via Guix-patches via writes: > * gnu/packages/qt.scm (inkbox): New variable. Thank you. Some comments follow. First, this should go to "ebook.scm" instead of "qt.scm". > + (source (origin You should instead a newline before "(origin". > + (method git-fetch) > + (uri > + (git-reference > + (url "https://alpinekobox.ddns.net/InkBox/inkbox/") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "126cqn0ixcn608lv2hd9f7zmzj4g448bnpxc7wv9cvg83qqajh5n")))) Nitpick: hash should go on the same line as base32. > + (build-system qt-build-system) > + (arguments > + '(#:tests? #f You should add a comment explaining why tests are disabled (i.e.: there is no tests). > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'prefix-opt > + (lambda* _ > + (substitute* "inkbox.pro" > + (("/opt/\\$\\$\\{TARGET\\}") (string-append (assoc-ref %outputs "out")))))) You should use (lambda* (#:key outputs #:allow-other-keys) ...) and then (assoc-ref outputs "out") instead. > + (replace 'configure > + (lambda* (#:key make-flags #:allow-other-keys) > + (apply invoke (cons "qmake" make-flags))))))) > + (native-inputs > + `(("qtbase" ,qtbase-5))) Does it fail with qtbase 6? > + (license license:gpl1))) License is actually gpl3, according to LICENSE file. Could you send an updated patch? Regards, -- Nicolas Goaziou