From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 51920@debbugs.gnu.org
Cc: phodina@protonmail.com
Subject: [bug#51920] [PATCH] gnu: Add inkbox.
Date: Sun, 21 Nov 2021 21:52:57 +0100 [thread overview]
Message-ID: <878rxhut7a.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <wGmep6ZhN8O7zQCG0Ef_9N_7thDBSi1NHnT1S3qh-0Y2dyWWANWKgCirnKjpSv4G83EXKTjJIPuD5MOR7DQF6Q4YQuJ3yis6S-xz3GzRrPA=@protonmail.com> (phodina via Guix-patches via's message of "Wed, 17 Nov 2021 11:50:45 +0000")
Hello,
phodina via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/qt.scm (inkbox): New variable.
Thank you. Some comments follow.
First, this should go to "ebook.scm" instead of "qt.scm".
> + (source (origin
You should instead a newline before "(origin".
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://alpinekobox.ddns.net/InkBox/inkbox/")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "126cqn0ixcn608lv2hd9f7zmzj4g448bnpxc7wv9cvg83qqajh5n"))))
Nitpick: hash should go on the same line as base32.
> + (build-system qt-build-system)
> + (arguments
> + '(#:tests? #f
You should add a comment explaining why tests are disabled (i.e.: there
is no tests).
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'prefix-opt
> + (lambda* _
> + (substitute* "inkbox.pro"
> + (("/opt/\\$\\$\\{TARGET\\}") (string-append (assoc-ref %outputs "out"))))))
You should use (lambda* (#:key outputs #:allow-other-keys) ...) and then
(assoc-ref outputs "out") instead.
> + (replace 'configure
> + (lambda* (#:key make-flags #:allow-other-keys)
> + (apply invoke (cons "qmake" make-flags)))))))
> + (native-inputs
> + `(("qtbase" ,qtbase-5)))
Does it fail with qtbase 6?
> + (license license:gpl1)))
License is actually gpl3, according to LICENSE file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-11-21 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 11:50 [bug#51920] [PATCH] gnu: Add inkbox phodina via Guix-patches via
2021-11-21 20:52 ` Nicolas Goaziou [this message]
2021-11-28 19:12 ` [bug#51920] [PATCH v2] " phodina via Guix-patches via
2021-11-29 21:21 ` bug#51920: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rxhut7a.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=51920@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).