From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4MoxMsTrzGE5ZgEAgWs5BA (envelope-from ) for ; Thu, 30 Dec 2021 00:14:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UIPBLsTrzGGwJQEAauVa8A (envelope-from ) for ; Thu, 30 Dec 2021 00:14:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 633015131 for ; Thu, 30 Dec 2021 00:14:12 +0100 (CET) Received: from localhost ([::1]:57892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2i95-0000T5-6K for larch@yhetil.org; Wed, 29 Dec 2021 18:14:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2i8w-0000SY-P8 for guix-patches@gnu.org; Wed, 29 Dec 2021 18:14:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2i8w-00056I-Fs for guix-patches@gnu.org; Wed, 29 Dec 2021 18:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2i8w-0008RH-7t for guix-patches@gnu.org; Wed, 29 Dec 2021 18:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52875] [PATCH] gnu: Add musikcube. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Dec 2021 23:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52875 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 52875@debbugs.gnu.org Received: via spool by 52875-submit@debbugs.gnu.org id=B52875.164081963932423 (code B ref 52875); Wed, 29 Dec 2021 23:14:02 +0000 Received: (at 52875) by debbugs.gnu.org; 29 Dec 2021 23:13:59 +0000 Received: from localhost ([127.0.0.1]:50633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2i8t-0008Qs-H1 for submit@debbugs.gnu.org; Wed, 29 Dec 2021 18:13:59 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:51705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2i8r-0008QZ-QW for 52875@debbugs.gnu.org; Wed, 29 Dec 2021 18:13:58 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 1AACF200007; Wed, 29 Dec 2021 23:13:50 +0000 (UTC) From: Nicolas Goaziou References: <8fe1260a15b00246f3987bb58dc1189fb07561f6.1640798010.git.leo@famulari.name> Date: Thu, 30 Dec 2021 00:13:49 +0100 In-Reply-To: <8fe1260a15b00246f3987bb58dc1189fb07561f6.1640798010.git.leo@famulari.name> (Leo Famulari's message of "Wed, 29 Dec 2021 12:13:30 -0500") Message-ID: <878rw380nm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640819652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=kFWqQ+fvsC5Z/zrr6gslc8KACSD7D1xmp7QeCpHUuYk=; b=OiLay5nt9d4kwQEInHrElkTagk1Ce0gTH8qi3TXheAD3wm8SSa8z1YOCXvYxHSaPwa0aqP uNUD5yE2wmy3SiZx+9wDSC1tJ8946ydJAwy/kvyTWsN4ghasU8/M+bAxsmYgZcYvC6siSW 0Sxt1Hck7Di63EM/KlwHPnfeURFh1XzwEbt6W6T4NCusPorTsQztiwvqZ4fqOVbCnI1HnE JfUSgLstmnia2ZXp5RXE7XsRe+P+dZJ0XJuWHk/krLY4SjCpo1yvQG4RUdzIZoejLCJSuL w8Wo661W+G96iyxny5vRiZ84spRkg6KQcc66l/QiXoiOy8l5uhKTLfa5aQNfUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640819652; a=rsa-sha256; cv=none; b=NEs9bK8J4HZ4FRsbSe63zgSnPkuoAzl7seZrSadMjcm7lw4LnRSJC67u2J//bHVEFliSuV AZmA525VcWKXjfb6xVWA0kIBH8LZZMkQp5bPVIoohSSEEMMtOVD0PHE7F/xPexta3LJNkU Ez1KeMwbv8ASswsx5ggxN7napDrMr5GhVxUbTwKw+NnEFehsmo7R+opfqHp8OCVBlDA49v MrbohFuLOVcXq7Ye9JVs4Gxx3My9BY+IQvf+rb+GN8/0KwgCKULQW9cbuzvKdpJqEPZ/60 7AyGnGkxuJm9Ro/FL8Vk8RHKbUhC16XYii3cuIleoiE34gpMRqO0LSXMP96yBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.17 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 633015131 X-Spam-Score: -3.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7movqpxplmSm Hello, Leo Famulari writes: > * gnu/packages/music.scm (musikcube): New variable. Nice! Thanks. > +(define-public musikcube > + (package > + (name "musikcube") > + (version "0.96.10") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/clangen/musikcube/") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "06myr83x8jvzlzchg3jsw1163n2lcsbmb176zgnx7xxa26jpdbh1")))) Nitpick: origin could go below source, and hash in front of base32. > + (build-system cmake-build-system) > + (arguments > + (list > + #:tests? #f ; No test suite Note that indentation is a bit off. > + #:configure-flags > + #~(list > + "-DCMAKE_BUILD_TYPE=Release" > + "-DENABLE_BUNDLED_TAGLIB=false" > + ;; Use the "wide" ncurses headers but don't look for them in an > + ;; ncursesw directory. For more info: > + ;; https://github.com/clangen/musikcube/wiki/building#compiler-cannot-find-ncurseswcursesh > + "-DNO_NCURSESW=true" > + ;; We will strip the binaries ourselves in the 'strip' phase. > + "-DDISABLE_STRIP=true"))) OOC, why are use using gexp since you do not ungexp later on? Wouldn't a regular quote, or even a quasiquote suffice? Otherwise, LGTM. Regards, -- Nicolas Goaziou