From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wByxFxMyWWIKPAAAgWs5BA (envelope-from ) for ; Fri, 15 Apr 2022 10:51:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aCO6DxMyWWK6fQEAG6o9tA (envelope-from ) for ; Fri, 15 Apr 2022 10:51:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C0F1849F for ; Fri, 15 Apr 2022 10:51:30 +0200 (CEST) Received: from localhost ([::1]:51496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfHft-0006kI-RR for larch@yhetil.org; Fri, 15 Apr 2022 04:51:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfHfS-00061O-QK for guix-patches@gnu.org; Fri, 15 Apr 2022 04:51:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfHfS-0004vC-6D for guix-patches@gnu.org; Fri, 15 Apr 2022 04:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nfHfS-0008Pf-31 for guix-patches@gnu.org; Fri, 15 Apr 2022 04:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50080] Commit updating SUNDIALS to 6.1.1. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Apr 2022 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50080 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Paul A. Patience" Cc: "50080@debbugs.gnu.org" <50080@debbugs.gnu.org> Received: via spool by 50080-submit@debbugs.gnu.org id=B50080.165001264932315 (code B ref 50080); Fri, 15 Apr 2022 08:51:02 +0000 Received: (at 50080) by debbugs.gnu.org; 15 Apr 2022 08:50:49 +0000 Received: from localhost ([127.0.0.1]:58095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfHfF-0008P7-CF for submit@debbugs.gnu.org; Fri, 15 Apr 2022 04:50:49 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:26138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfHfD-0008Os-7h for 50080@debbugs.gnu.org; Fri, 15 Apr 2022 04:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=3ZudWQwmzojSIya8vAvSEASkAUYW1MNTWIitMwYEEBY=; b=UaAcSNpvObuuiDw8MuqJ9J46XrAmXNgxfr35Iy7HT57+Q1C1aFe4IYBF B4vrcGmgyr4Sdegu9dm1hNaj8eJpedsVaEL6USfvAHkd8GNavaEQ4YP8k VjSZz1Fe3pDqlwlbY8kFj9A7BAfxfapMNockQ92vXj3m547s34SCa7SZv I=; X-IronPort-AV: E=Sophos;i="5.90,262,1643670000"; d="scan'208";a="11596016" Received: from unknown (HELO ribbon) ([193.50.110.136]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2022 10:50:41 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Germinal an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Apr 2022 10:50:39 +0200 In-Reply-To: (Paul A. Patience's message of "Thu, 14 Apr 2022 18:06:59 +0000") Message-ID: <878rs67msg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650012690; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3ZudWQwmzojSIya8vAvSEASkAUYW1MNTWIitMwYEEBY=; b=cY+TZpddsI3iCaa/h7iE14SSnSCf9bNtPNAd0A5XPVzoKW3ZrUaJqvMxsGhxUMecUJXivQ k9EY9ZG+QEPjlklXWSVZ9PJy00aqSkrO2WSaGlfxpi1BdTC+6iGnQMMR9t6292NAE1VIJH IDO401wtbiAli0AjqdvQN9hObW2iJedZ5RW/TZuDA2/+p8xgeS42VS2nf+SSD2Rqdiyd3A DoVD2JUbPNo/RV7c60acx78wpQ2R5GYfdaL2n56UfyzLx9EiI2xtktaj2VunXbZ00UGXhw QLFg14fKmR11CFFNojubMMt+MOjs+eCWEhUiu8N/W6Pfxk/XcdtAS/aIB4XvGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650012690; a=rsa-sha256; cv=none; b=CBUUCX8hfc8II/8yVaIHMzWqm61LRgOFfcGZsCXl/lGy92clMJzH/1HzJ2HKEqAPUrTyMU hw2QuHl4SzVOZnoBh7BXpHvr2Sa6Bu3rdw0RkMwD95W2odMkL9o5QhzFm27krwp6rOCsLM HnjHaa1LDBLrgx8spoJgCpPQ9i8Oeau47PVVNmcyXJpvj5W210qga5Zq63IemxFuKeJR9s Gzou2qs+ieTDn+7RiCY5HYCu/MqyrVv7aWd/YqyigAuEQd7/y1DxA4R3GYAuRDasniRaTY T4G74tK9zC4m0POSk0Ba513YehpSQSp39+cMyboQafg+OzyvZkScCAylI6HoFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=UaAcSNpv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=UaAcSNpv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9C0F1849F X-Spam-Score: 5.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: srKPetHC4Ocg Hi Paul, "Paul A. Patience" skribis: > I see that you have updated SUNDIALS to 6.1.1. > When last I updated it (to 5.7.0) [1], I encountered issues in 32-bit vs = 64-bit > indices, which I see no mention of in your commit. > There were also some other issues which I mentioned in my patch series' > commit messages. > > Do you know if the update to 6.1.1 renders the issues extraneous? Thanks for bringing it up, I had overlooked this patch of yours=E2=80=94my apologies for that. I don=E2=80=99t know if the new version defaults to 64= -bit or 32-bit indices. > A good test would be adding SUNDIALS as a propagated input to > deal.II. I tried that; this leads to a build failure apparently due to changes in the API of SUNDIALS: --8<---------------cut here---------------start------------->8--- /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/source/sundials/arkode.cc: = In instantiation of =E2=80=98void dealii::SUNDIALS::ARKode::rese t(double, double, const VectorType&) [with VectorType =3D dealii::Vector]=E2=80=99: /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/source/sundials/arkode.cc:8= 38:18: required from here /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/source/sundials/arkode.cc:6= 35:31: error: too few arguments to function =E2=80=98void* ARKStepCreate(ARK RhsFn, ARKRhsFn, realtype, N_Vector, SUNContext)=E2=80=99 635 | arkode_mem =3D ARKStepCreate( | ~~~~~~~~~~~~~^ 636 | explicit_function ? &t_arkode_explicit_function := nullptr, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~ 637 | implicit_function ? &t_arkode_implicit_function := nullptr, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~ 638 | current_time, | ~~~~~~~~~~~~~=20=20=20=20=20=20=20=20=20=20=20=20 639 | initial_condition_nvector); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/sourc= e/sundials/arkode.cc:45: /gnu/store/vyl9wll72m9jqc21idxrxnmb7rm0lkf7-sundials-6.1.1/include/arkode/a= rkode_arkstep.h:112:23: note: declared here 112 | SUNDIALS_EXPORT void* ARKStepCreate(ARKRhsFn fe, ARKRhsFn fi, | ^~~~~~~~~~~~~ /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/source/sundials/arkode.cc: = In instantiation of =E2=80=98void dealii::SUNDIALS::ARKode::setu p_system_solver(const VectorType&) [with VectorType =3D dealii::Vector]=E2=80=99: /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/source/sundials/arkode.cc:8= 38:18: required from here /tmp/guix-build-dealii-9.3.2.drv-0/dealii-9.3.2/source/sundials/arkode.cc:7= 10:30: error: too few arguments to function =E2=80=98_generic_SUNLinearSolve r* SUNLinSol_SPGMR(N_Vector, int, int, SUNContext)=E2=80=99 710 | SUNLinSol_SPGMR(y_template, | ~~~~~~~~~~~~~~~^~~~~~~~~~~~ 711 | PREC_NONE, | ~~~~~~~~~~ 712 | 0 /*krylov subvectors, 0 uses default= */); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ --8<---------------cut here---------------end--------------->8--- I=E2=80=99m probably less familiar than you with these two packages; what w= ould you suggest? Please keep me Cc=E2=80=99d and hopefully we can address these issues for g= ood this time! Thanks, Ludo=E2=80=99.