From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: John Kehayias <john.kehayias@protonmail.com>, 56127@debbugs.gnu.org
Subject: [bug#56127] [PATCH] gnu: polybar: Update to 3.6.3.
Date: Wed, 22 Jun 2022 15:42:50 +0200 [thread overview]
Message-ID: <878rpou84l.fsf@jpoiret.xyz> (raw)
In-Reply-To: <x7X8vmU7JxtyWWX_8daSzQTPTN90_PMPsSFKjAVkqrwd3wUnV1d3iPYdFbDDfaMHy9Jv6ApDam5D7blVNggGgxanv9UxcLB1SX98rsOQ0mU=@protonmail.com>
Hello John
John Kehayias via Guix-patches via <guix-patches@gnu.org> writes:
> Hi Guix,
>
> Here is a patch to update polybar. There were some slight tweaks needed: new input, remove unneeded native-input, and change where the default configuration file is installed (from /etc) to #$output/etc/xdg.
>
> This last change may look slightly different from the default behavior, but this will put it where it should be found using XDG_CONFIG_DIRS. This was made in the change to polybar that also moved/altered the configuration installation: https://github.com/polybar/polybar/commit/282b0f4e73e9cbb68afd6e168c472e3f422e9a6f#diff-6b4c594394f4751f9012dc3889b278312f0e7275ab48edbe3b02d434e183aa52
>
> I tested that it builds and polybar will find this default configuration file when no config is otherwise found or specified. The default bar looked fine to me. Note that I did test this where I do have XDG_CONFIG_DIRS set for that profile anyway.
Looks good to me as-is, builds and runs fine, although I'd prefer to
keep the file at /etc/, and patch src/utils/file.cpp to look for
$output/etc/polybar/config.ini. That way, polybar would work without a
config file even when not installed. Also, if you have the time, could
you move the native-inputs to the new style as an additional commit?
WDYT?
--
Josselin Poiret
next prev parent reply other threads:[~2022-06-22 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 18:21 [bug#56127] [PATCH] gnu: polybar: Update to 3.6.3 John Kehayias via Guix-patches via
2022-06-22 13:42 ` Josselin Poiret via Guix-patches via [this message]
2022-06-22 14:35 ` John Kehayias via Guix-patches via
2022-06-23 10:16 ` Josselin Poiret via Guix-patches via
2022-06-23 14:40 ` [bug#56127] [PATCH 1/2 v2] " John Kehayias via Guix-patches via
2022-06-23 20:29 ` bug#56127: [PATCH] " Ludovic Courtès
2022-06-23 14:41 ` [bug#56127] [PATCH 2/2] gnu: polybar: Simplify inputs John Kehayias via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rpou84l.fsf@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=56127@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).