From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SE/5D2XMtGL5sAAAbAwnHQ (envelope-from ) for ; Thu, 23 Jun 2022 22:26:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AFfQD2XMtGIYqQAA9RJhRA (envelope-from ) for ; Thu, 23 Jun 2022 22:26:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D07AC8947 for ; Thu, 23 Jun 2022 22:26:12 +0200 (CEST) Received: from localhost ([::1]:53470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4TP2-00033F-2h for larch@yhetil.org; Thu, 23 Jun 2022 16:26:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOs-00030t-2O for guix-patches@gnu.org; Thu, 23 Jun 2022 16:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4TOr-0004Gh-Qd for guix-patches@gnu.org; Thu, 23 Jun 2022 16:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4TOr-00063P-Mx for guix-patches@gnu.org; Thu, 23 Jun 2022 16:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55961 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55961@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: Nicolas Graves via Guix-patches via , 55961@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165601596023263 (code B ref -1); Thu, 23 Jun 2022 20:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2022 20:26:00 +0000 Received: from localhost ([127.0.0.1]:40031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TOp-000639-PM for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:26:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:60906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TOo-000630-V8 for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOo-0002z0-6T for guix-patches@gnu.org; Thu, 23 Jun 2022 16:25:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOl-0004Ez-8k; Thu, 23 Jun 2022 16:25:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=vo/SvIrHUX3pf7NCy4JjuV4Kxf+Zdl/MHHbY3f+n5bw=; b=Sg9o5tq6aAUjK7Qh7pq8 J2CqZ3vSlnYOoE6mEkZT89EFxZ/00s/lsKX9lRKglyhBXXL3t5vQWsZ2fjOI0TKiCfty++CbQ69rz FsnDw2rQYayUHHQc4qpwRnb4b/gJZBcvomWX/raqHyGpHv0ZM9vH/33WyCwQajIPjrCSgmTyvRubF vNTcPFzNT2qMKvCFm/hfnaADiRMgJ3nw++K7MEQUfyRuiT/grl0N09PkXAfJNWCRgCRJ3rI2IBUpH SpgyrzrFx+eDh0MFo+RfNmjzFl8W2qXDE/tckW8YSD4pEI93Kr+XnOyjwlI150R+j4D+MMKPIm3O6 qoh1RnARHVFP4Q==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:33124 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TOj-0001ON-Ov; Thu, 23 Jun 2022 16:25:55 -0400 From: Marius Bakke In-Reply-To: <20220614094954.15197-3-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-3-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 22:25:52 +0200 Message-ID: <878rpnrusv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656015972; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vo/SvIrHUX3pf7NCy4JjuV4Kxf+Zdl/MHHbY3f+n5bw=; b=evLNw0XIasN2qSOIyBaFr5mYo0KZa+1g+NswIBpcZEHEMcIBNK+LDAEUjMKWtqHq+cpx0X R1+aq2CgNdR7ZOyjBgxPNrjAyJkj+GgtyjVx7ywMtfime56yfALl9HYS/d5R2rWiYa90Vo a0bYYRBEbTMtiZjKXgHMIhHuJgeRgQSA6qjZlIJdVxvDz4QfVIF5+tKkHW12RTewozS5+3 r2T3ga8Y5UXoxn8BM1rKoeY1wpQdMO8atfd7BKKKgBUJDamemnkd8pIPz4MemVmVRrjh8M kqg7Slz2YDM1D81nYwtwkMUbXJjKI5uM5KgpYPxtMxZqHc3YaIT1ka6VSbRFNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656015972; a=rsa-sha256; cv=none; b=b0LJejxWi65IdtstEpCvD/W9RfBfJ2Y2RLO7gYYbP80QjvqaLfsHoW2HUpyaA4tkV/4x4A NF39Y7xPHqwGzISfsWy6ohLVcK+aH+l9x6G7HivAWg4vJZ8lf7sdLnQhDylvZxLuh4ZfnM Az9qenmm5F0orzlsJwqEiSZrNgf92fn05G5abY5hDl/IffCOeC+K+7+A7q5hW+dzzsxZfr 7XVi4joWw2gaTwzy3KfXR9Se+CDk7pYLkz0jnh6qKInutSsgIZLH0OP6Nptp4qxT3bMLl/ EiOAD0/atDJ7D/FPofruKauOdVq686VC1mssyTlqTV1FMNcgJKitBvDSQkZkPw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Sg9o5tq6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Sg9o5tq6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D07AC8947 X-Spam-Score: -5.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: a7cN6r+xWPvB --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-protocol-buffers-schema): New variable. > --- > gnu/packages/node-xyz.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm > index af3745f601..3f49955e29 100644 > --- a/gnu/packages/node-xyz.scm > +++ b/gnu/packages/node-xyz.scm > @@ -233,6 +233,36 @@ (define-public node-oop > while being as light-weight and simple as possible.") > (license license:expat)))) >=20=20 > +(define-public node-protocol-buffers-schema > + (package > + (name "node-protocol-buffers-schema") > + (version "3.6.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/mafintosh/protocol-buffers-schema") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0lnckxj14jzsnfxdd5kmlwrac43c214bv8i2g5rdldymlpxzrz1v")))) > + (build-system node-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--product= ion") > + #t))))) Same comments as before regarding arguments and indentation. > + (home-page "https://github.com/mafintosh/protocol-buffers-schema") > + (synopsis "No nonsense protocol buffers schema parser written in Jav= ascript") Avoid marketing words such as "no-nonsense". :-) Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTMUA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHdRmAD/SE0vNedfCx2smqbiRQ3uDI5zdMDqdEgiM2L8 vi7CHh0BAK4vQLaW3OtuJfc1XN1rloAWf2EcoZzqatVSRxbZbNkM =3tiN -----END PGP SIGNATURE----- --=-=-=--