From: Mathieu Othacehe <othacehe@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 57646@debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#57646] [PATCH] etc: teams: Add regular expression support to scopes.
Date: Mon, 12 Sep 2022 15:49:32 +0200 [thread overview]
Message-ID: <878rmoaej7.fsf@gnu.org> (raw)
In-Reply-To: <87a674nakk.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 12 Sep 2022 12:30:35 +0200")
Hey,
> * the dependency on Guile-Git means that the script must be run inside a
> suitable environment now, whereas previously it had no dependencies
> other than Guile. If we can assume that people use Guix perhaps we
> should do what doc/build.scm does and use Guix to arrange for
> dependencies to be available.
Right, for now I went for the easiest solution and proposed the following
example in the documentation:
--8<---------------cut here---------------start------------->8---
$ guix shell -D guix
[env]$ git send-email $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch
--8<---------------cut here---------------end--------------->8---
> * I don’t like the “if” + “null?” pattern:
>
> + (if (not (null? (team-scope team)))
> + (format #f "scope: ~{~s ~}~%" (team-scope team))
> + ""))
>
> I’d prefer using match:
>
> (match (team-scope team)
> (() "")
> (scope (format #f "scope: ~{~s ~}~%" scope)
>
> * With Liliana’s added support for regexes, the previous patch to record
> scopes for the installer etc should be adjusted.
Fixed!
Thanks,
Mathieu
next prev parent reply other threads:[~2022-09-12 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 15:16 [bug#57646] [PATCH 0/3] teams: Add scope support Mathieu Othacehe
2022-09-07 15:21 ` [bug#57646] [PATCH 1/3] etc: " Mathieu Othacehe
2022-09-07 15:21 ` [bug#57646] [PATCH 2/3] etc: teams: Define core team scope Mathieu Othacehe
2022-09-07 15:21 ` [bug#57646] [PATCH 3/3] etc: installer: Define installer " Mathieu Othacehe
2022-09-09 15:27 ` [bug#57646] [PATCH] etc: teams: Add regular expression support to scopes Liliana Marie Prikler
2022-09-11 16:36 ` Mathieu Othacehe
2022-09-12 10:30 ` Ricardo Wurmus
2022-09-12 13:49 ` Mathieu Othacehe [this message]
2022-09-12 13:55 ` [bug#57646] [PATCH v2 1/4] etc: teams: Add scope support Mathieu Othacehe
2022-09-12 13:55 ` [bug#57646] [PATCH v2 2/4] etc: teams: Add regular expression support to scopes Mathieu Othacehe
2022-09-12 13:55 ` [bug#57646] [PATCH v2 3/4] etc: teams: Define core team scope Mathieu Othacehe
2022-09-12 13:55 ` [bug#57646] [PATCH v2 4/4] etc: installer: Define installer " Mathieu Othacehe
2022-09-24 10:21 ` [bug#57646] [PATCH 0/3] teams: Add scope support Ludovic Courtès
2022-09-25 11:54 ` bug#57646: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rmoaej7.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=57646@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).