From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AIk9NOcsW2MInQAAbAwnHQ (envelope-from ) for ; Fri, 28 Oct 2022 03:14:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8IYiNOcsW2MtGwEAauVa8A (envelope-from ) for ; Fri, 28 Oct 2022 03:14:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 79BA817360 for ; Fri, 28 Oct 2022 03:14:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooDvm-0003Oi-UX; Thu, 27 Oct 2022 21:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooDvl-0003OX-D3 for guix-patches@gnu.org; Thu, 27 Oct 2022 21:13:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooDvi-0004Ht-Ip for guix-patches@gnu.org; Thu, 27 Oct 2022 21:13:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooDvi-00031d-7K for guix-patches@gnu.org; Thu, 27 Oct 2022 21:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58587] [PATCH 04/14] build-system: Add pyproject-build-system. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Oct 2022 01:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 58587-done@debbugs.gnu.org, Lars-Dominik Braun Received: via spool by 58587-done@debbugs.gnu.org id=D58587.166691957911621 (code D ref 58587); Fri, 28 Oct 2022 01:13:02 +0000 Received: (at 58587-done) by debbugs.gnu.org; 28 Oct 2022 01:12:59 +0000 Received: from localhost ([127.0.0.1]:59785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooDvf-00031M-1w for submit@debbugs.gnu.org; Thu, 27 Oct 2022 21:12:59 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:45662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooDvd-00031A-9d for 58587-done@debbugs.gnu.org; Thu, 27 Oct 2022 21:12:57 -0400 Received: by mail-qk1-f172.google.com with SMTP id i10so2414297qkl.12 for <58587-done@debbugs.gnu.org>; Thu, 27 Oct 2022 18:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NdWztyMZq26OMPQ2x2p4/Cxj9pYdH1x5zLL/21HCo64=; b=bwYWnKenHqzkZA6ElAr6QAaqoP3Nl+nx9Pqe4dAmcakAJ1B2momBJjryJHoWzBo+KK SlyJP5UrjdN+b7zPtwV72ochaORQC6MuvA492ngKESMdvQcyJv5ngmQtN953+HTdK3RY aqshZNOHWf2x84lxBrxrOVTkcTPzqHsTOs4p8kifkQKiHKVkfk3RoJGe5gc8GRlNErWR vWmI/0UOESYZrjxpzC9klKJu7nOlMkPUvNBzwAUf3Rj8aV4puw6p/F2yZYgUdsxKaJAB xu6WqPvRn9IaNYOojXkhwXVSwHk4+abE4VJJRHr4Drx3HK2+he4x4TfJZoDG3R8YdciJ qclw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NdWztyMZq26OMPQ2x2p4/Cxj9pYdH1x5zLL/21HCo64=; b=ID7zPrBTNDfoj0y5Mqu4/XakYdXLetkCIRwnKpUJuvJmSbKf231xgPhRQJ2m519iDH SbJserLGpwrViGWGKO8S5d63zGonCrZwIrlBJvmEPsS8Ztr2kqkmjfMh6mdzzUQKaAL6 a+ENgqWz2TuVus7mL7r5IRIMmNl0q08uvJrLIeSfwFpQ51xDdwp9YiiFHGh/0IBe85hi FUvGgD6ilzYe3OKBXQYjihB/dIU73e4XCfxIQeKg8kJXBOPQJ07wq9XVvoeXmT8mno1/ x9l4eMR5q2B10l6DhhGXADBIb2fB6oEaacqMWANO/Vs52VZa75RqQMKy5uV6M9lZpeA0 beBw== X-Gm-Message-State: ACrzQf1KwRoOuAVoKY7WzJyWOT5HepSPM9vgMpv5gESs/LAxLw69HaKE 5ZM+nqg0Im1dJoSZcgLX+BU= X-Google-Smtp-Source: AMsMyM6MsH9kupbeUqpbOa8O+hlWcT3ZsYWNwnO4Ld1cGP7rXznL3N3zVT0vzG5IUD+yJYRn8dDNVA== X-Received: by 2002:a05:620a:2b9a:b0:6f9:f67a:fa1d with SMTP id dz26-20020a05620a2b9a00b006f9f67afa1dmr3790334qkb.185.1666919571668; Thu, 27 Oct 2022 18:12:51 -0700 (PDT) Received: from hurd (dsl-152-179.b2b2c.ca. [66.158.152.179]) by smtp.gmail.com with ESMTPSA id r3-20020ac87ee3000000b0039442ee69c5sm1619776qtc.91.2022.10.27.18.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 18:12:51 -0700 (PDT) From: Maxim Cournoyer References: <20221017200624.4076-1-marius@gnu.org> <20221017201201.4808-1-marius@gnu.org> <20221017201201.4808-4-marius@gnu.org> <87zgdhjqgr.fsf@gmail.com> <871qqttc3d.fsf@gnu.org> <87y1t1rrjs.fsf@gnu.org> Date: Thu, 27 Oct 2022 21:12:49 -0400 In-Reply-To: <87y1t1rrjs.fsf@gnu.org> (Marius Bakke's message of "Thu, 27 Oct 2022 21:32:23 +0200") Message-ID: <878rl0iwdq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666919655; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NdWztyMZq26OMPQ2x2p4/Cxj9pYdH1x5zLL/21HCo64=; b=bMT+BmryA0m4sC3VERFw88D8SSToKfenXzyZatyf1Om6TEWy2lAt7ZK1jbHAr4ykzyC3/q IR5KlSioGNAqpgGaOYSYu52BGzheusjgAWsJcITUlsvtb0eYDXvzR20mdQJYRKbFTH30eZ Bc4BFPBuz2B72q1Vry/G3iW/sfcbAd15+pCsiFuG6QLQKQnjBYm636BT6lMJUHFvjtrRWv ferF+Tgguc0v2Gtn16R+3tR8I+KHviAB5hX+mjQENW0slicPVFHd0SvChj6qbEM7FYDbTS F9jHHoWf1/cI0R9xczu34aN1m61rAEo8rGVMb+zyvivfXzTnCYPsQAMJCCd9xw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666919655; a=rsa-sha256; cv=none; b=g2HBKUE3oV3OBRxozW90BQjLPzjQ1coQbGtu8fMyaWj65/oXxgM5GD/N9QiMXvLUxZKtFd Hdoioc6pUh5pBLc34wxHwenCGexK6Cl/dEkIwSLW+T8IXDHMVU80TS+DO3j5p+oZOKcLx6 6zTXWUivV6zhDDRbiL2gdBwny0XOUGukb3HwTCAclXj7AnDBAeF9qqy/+dBNRvkARD4Ej3 NX0MmRXD7w+4tdz06PbYIlRQ6CSnLl/a8j8QvUAPzLPap+Bkz7m/HbORTZcNk7HOdUdvLc xBWjFVIsRqx5Ld/5n2B8y0er2d1dMD83IBl29JbKDylzj5UEVoKh8nsvEyhJiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bwYWnKen; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bwYWnKen; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 79BA817360 X-Spam-Score: 7.59 X-Migadu-Scanner: scn1.migadu.com X-TUID: t7iHCz/PRYqD Hi Marius, Marius Bakke writes: > Marius Bakke skriver: > >> Maxim Cournoyer skriver: >> >>> Hello, >>> >>> Marius Bakke writes: >>> >>>> From: Lars-Dominik Braun >>>> >>>> + ;; Prefer pytest >>>> + (if pytest 'pytest #f) >>>> + (if nosetests 'nose #f) >>>> + (if nose2 'nose2 #f) >>>> + ;; But fall back to setup.py, which should work for most >>>> + ;; packages. XXX: would be nice not to depend on setup.py here? fails >>>> + ;; more often than not to find any tests at all. Maybe we can run >>>> + ;; `python -m unittest`? >>>> + (if have-setup-py 'setup.py #f)))) >>>> + (format #t "Using ~a~%" use-test-backend) >>>> + (match use-test-backend >>>> + ('pytest >>>> + (apply invoke (cons pytest (or test-flags '("-vv"))))) >>>> + ('nose >>>> + (apply invoke (cons nosetests (or test-flags '("-v"))))) >>>> + ('nose2 >>>> + (apply invoke (cons nose2 (or test-flags '("-v" "--pretty-assert"))))) >>> >>> I think I'd leave the defaults in and document it that way. >> >> By leave, you mean: >> >> (apply invoke "pytest" "-vv" test-flags) >> >> ? > > I made this change in e944734ef9afa1ac9b46579934482b7d909ed24e. > > The patches are now merged! Very nice! Well done! -- Thanks, Maxim