From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eEY2M0WlmWOAmgAAbAwnHQ (envelope-from ) for ; Wed, 14 Dec 2022 11:28:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6EU6M0WlmWP28wAA9RJhRA (envelope-from ) for ; Wed, 14 Dec 2022 11:28:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D21E22B6F for ; Wed, 14 Dec 2022 11:28:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Owj-0002ay-BN; Wed, 14 Dec 2022 05:25:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Owh-0002a8-0b for guix-patches@gnu.org; Wed, 14 Dec 2022 05:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Owg-0008EM-Gq for guix-patches@gnu.org; Wed, 14 Dec 2022 05:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5Owg-0007jU-CP for guix-patches@gnu.org; Wed, 14 Dec 2022 05:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Dec 2022 10:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Vagrant Cascadian Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.167101348629712 (code B ref 59513); Wed, 14 Dec 2022 10:25:02 +0000 Received: (at 59513) by debbugs.gnu.org; 14 Dec 2022 10:24:46 +0000 Received: from localhost ([127.0.0.1]:38150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5OwQ-0007jA-5j for submit@debbugs.gnu.org; Wed, 14 Dec 2022 05:24:46 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5OwN-0007j4-T3 for 59513@debbugs.gnu.org; Wed, 14 Dec 2022 05:24:44 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 8111427BBE9; Wed, 14 Dec 2022 10:24:42 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 81f67cd7; Wed, 14 Dec 2022 10:24:41 +0000 (UTC) References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> <87bko64xfq.fsf@contorta> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Wed, 14 Dec 2022 10:21:12 +0000 In-reply-to: <87bko64xfq.fsf@contorta> Message-ID: <878rjanuzd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671013701; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=/h1kzzthjZEmuWwBhURHVjigr/Hs1ddEv6uta1CB3+I=; b=X2RGy8aKGFP23OcezzxwPNHzQVRceSwWRGwdMf7EdaQX2UjjnwtwKXWl+l6znPHNyqqNGO NsNXDV1CoPvw+950AitkrK6wYOIOb+HCGybLPAXFG+uMUHOdQpOQmSrc/LXtBYrk6ku2uE xKY5pyqUO222Wdxw4d2ezlNRtJFOx2slOePSRo8BPQE5qJg2IvMelkEE+AHWHK++Qnzc+3 o4NvOlyTnZpJFo5H9gJswxgtHrJwKEpKGzVsESN0PATyRBsI5RahanR9XYi3HOccKQFys6 jQmWuF2vhBIkUu9+keqgzVoplcbzSk9F6itXLEaOusa1+s86C/4JtUcPC4cr3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671013701; a=rsa-sha256; cv=none; b=eDh3FSciGivAWtUokv7bo6R9Hdcf7GJCbV+eVQ21MR3HGU29nat4BE5f1e3SrplQImYJvo FKZtLE8iPJgW9YU3huMrwzgWmWp+yiSHF7Q/T/VWK7+zd9IuRQ3JZb/+fDSBEB38Jg4S77 bnH6qDNnBKGJVaLQMyp1G/jsZMtcgeVDTc8YGLRwKSGJonfAnsB/5OpI/NQQKaA/LxKxPW xtbjVgPwZyreuSLlNIi30TfsHMh7gyPqs9WiqM7+q0xr/zoXeSFTVh6eFNbVyqXbdCeiHy rfCDQacoyTygRM989Oww9LS59FZzV6dnDXOHlJd7TvzaYvyiQlmtd9TN5SQ0bw== X-Migadu-Spam-Score: -4.17 X-Spam-Score: -4.17 X-Migadu-Queue-Id: 4D21E22B6F X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: uuwWgYO86MjA --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vagrant Cascadian writes: > [[PGP Signed Part:Undecided]] > On 2022-12-08, Christopher Baines wrote: >> Only suggest waiting one week for review for simpler changes, wait two w= eeks >> for more significant changes. > ... >> +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing >> +list fills the patch-tracking database (@pxref{Tracking Bugs and >> +Patches}). It also allows patches to be picked up and tested by the >> +quality assurance tooling; the result of that testing eventually shows >> +up on the dashboard at >> +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where >> +@var{number} is the number assigned by the issue tracker. Leave time >> +for a review, without committing anything (@pxref{Submitting Patches}). >> +If you didn=E2=80=99t receive any reply after one week (two weeks for m= ore >> +significant changes), and if you're confident, it's OK to commit. > > My one concern here for things that I tend to work on is > diffoscope... it has such a large dependency graph(?) because it > supports so many file formats, it pulls in quite a lot for the test > suites... > > In a week or two of changes between submission and being able to push to > master, I'd worry that you could end up with a diffoscope that wouldn't > build because of changes to one of it's (native-)inputs or whatnot > because of changes to master in the previous week... > > > That said, overall, I think sending everything through guix-patches is a > good change, even if my lazier self pouts a little at having to deal > with more process for seemingly simple things. :) I think that's a valid concern. The QA tooling is affected similarly, in that it tests against the latest processed revision when the patch is picked up, but things could change in between the testing happening and it being merged. Remember that these time periods are only when no review takes place. My hope is that manual review can happen sooner than one or two weeks after patch submission, therefore enabling making changes more quickly. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOZpGZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfJYw/9Ho7K80EadW1peOtIn/AyTFdeW3lAN2+5 dgEKbf4Nc0Al+lhHK7v5ZuL5oLSP1VYqpvjqVtPIkdFMBhLdaKnuVc23S8cNtD+j fKA9HN0TY+rILwfkfokspMqq2F4V2frYi/ywUS2xanqHZltvj3i7Z7U+wFjubSvm hGWwx24HFJOC1Enh62kNiM61NBQgvW+kMmTeIz2BanNYZJrOKJdUKNm5375TQM3A rn0LnJx7PUwEz06qO0FgZE+k4F5cIxoPUHbZwoz8WucwCLl3fQZRYG5F+ZclPDwh tWb4VeyM92rScazHMqksiOKRcKQaUK66+HAPobGW2U3i8XLnM/KHbyhrtTyGqz2J XvkMd7RE2kgsL/0AC7n+lQq9VYxnYi3wh3SpAdgv2ucurW9xve+TC5WRWNJg7d3e fL5kQ2YJh5dn3Gxdez3Fd9zvoJG5vXs8ggqN+vWyixMlHgt7wx6ntAb0kq7kDigC TC/YBYpYuatLjpj7+WFzS0eTuxl60dkdJnqJ3yVIkwzBGulo2CG4VOocKEuoTvhi ooXSij1DCw5DRf2gb++2pedYR9zyFCRjaAb/h5GTG6P65UIJ+44FPDPn0JiRefD6 40A6rIiJqRuRIM6P6LTr43LuouQgdCJLj005b87hnwZm0q1Qz9nTSdbNeBWS1dYw F4iTl6R5d6c= =hJw0 -----END PGP SIGNATURE----- --=-=-=--